]> git.eshelyaron.com Git - emacs.git/commitdiff
* lisp/progmodes/grep.el (grep-filter): Don't trip on partial lines.
authorStefan Monnier <monnier@iro.umontreal.ca>
Thu, 12 May 2011 15:10:17 +0000 (12:10 -0300)
committerStefan Monnier <monnier@iro.umontreal.ca>
Thu, 12 May 2011 15:10:17 +0000 (12:10 -0300)
lisp/ChangeLog
lisp/progmodes/grep.el

index bac4931f4eb0bd918b26ea579be476e5766899b2..5204622f641462ea513c7bf8e58f07a2a5cbb5ba 100644 (file)
@@ -1,5 +1,7 @@
 2011-05-12  Stefan Monnier  <monnier@iro.umontreal.ca>
 
+       * progmodes/grep.el (grep-filter): Don't trip on partial lines.
+
        * shell.el (shell-completion-vars): New function.
        (shell-mode):
        * simple.el (read-shell-command): Use it.
index 12295efc2d126918628d58f3acecef4d3e6c01ab..143220ad28af89c79824fb8010e63644bf304fd2 100644 (file)
@@ -476,17 +476,23 @@ Set up `compilation-exit-message-function' and run `grep-setup-hook'."
   "Handle match highlighting escape sequences inserted by the grep process.
 This function is called from `compilation-filter-hook'."
   (save-excursion
-    (let ((end (point-marker)))
-      ;; Highlight grep matches and delete marking sequences.
+    (forward-line 0)
+    (let ((end (point)))
       (goto-char compilation-filter-start)
-      (while (re-search-forward "\033\\[01;31m\\(.*?\\)\033\\[[0-9]*m" end 1)
-       (replace-match (propertize (match-string 1)
-                                  'face nil 'font-lock-face grep-match-face)
-                      t t))
-      ;; Delete all remaining escape sequences
-      (goto-char compilation-filter-start)
-      (while (re-search-forward "\033\\[[0-9;]*[mK]" end 1)
-       (replace-match "" t t)))))
+      (forward-line 0)
+      ;; Only operate on whole lines so we don't get caught with part of an
+      ;; escape sequence in one chunk and the rest in another.
+      (when (< (point) end)
+        (setq end (copy-marker end))
+        ;; Highlight grep matches and delete marking sequences.
+        (while (re-search-forward "\033\\[01;31m\\(.*?\\)\033\\[[0-9]*m" end 1)
+          (replace-match (propertize (match-string 1)
+                                     'face nil 'font-lock-face grep-match-face)
+                         t t))
+        ;; Delete all remaining escape sequences
+        (goto-char compilation-filter-start)
+        (while (re-search-forward "\033\\[[0-9;]*[mK]" end 1)
+          (replace-match "" t t))))))
 
 (defun grep-probe (command args &optional func result)
   (let (process-file-side-effects)