* nsterm.m (ns_defined_color): Block input. Suggested by Mike

<deactivated@gmail.com> (Bug#3605).

diff --git a/src/ChangeLog b/src/ChangeLog
index f27aed26bef9ddd2006d4b90a4f5ed233ea1f249..941c394f107143a390b868b14ede5c525d160b6e 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2010-01-31  Chong Yidong  <cyd@stupidchicken.com>
+
+       * nsterm.m (ns_defined_color): Block input.  Suggested by Mike
+       <deactivated@gmail.com> (Bug#3605).
+
 2010-01-31  David De La Harpe Golden  <david@harpegolden.net>
 
        * fileio.c (Frename_file): Correctly rename symlinks to

diff --git a/src/nsterm.m b/src/nsterm.m
index 3951fdc2e58967df25d2b9d0e5a7244847bc148f..8f3233f9fde51148ce6cc887079337c8896e7de4 100644 (file)
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -1552,19 +1552,19 @@ ns_defined_color (struct frame *f, char *name, XColor *color_def, int alloc,
          Return 0 if not found
    -------------------------------------------------------------------------- */
 {
-  NSColor *temp;
-  int notFound = ns_get_color (name, &temp);
-
+  NSColor *col;
   NSTRACE (ns_defined_color);
 
-  if (notFound)
-    return 0;
-
+  BLOCK_INPUT;
+  if (ns_get_color (name, &col) != 0) /* Color not found  */
+    {
+      UNBLOCK_INPUT;
+      return 0;
+    }
   if (makeIndex && alloc)
-      color_def->pixel = ns_index_color(temp, f); /* [temp retain]; */
-
-  ns_query_color (temp, color_def, !makeIndex);
-
+    color_def->pixel = ns_index_color (col, f);
+  ns_query_color (col, color_def, !makeIndex);
+  UNBLOCK_INPUT;
   return 1;
 }