Avoid needless casts with XSAVE_POINTER.

* alloc.c (mark_object) [GC_MARK_STACK]:
* dired.c (directory_files_internal_unwind):
* fileio.c (do_auto_save_unwind):
* gtkutil.c (pop_down_dialog):
* keymap.c (map_keymap_char_table_item):
* lread.c (load_unwind):
* nsmenu.m (pop_down_menu):
* print.c (print_object) [GC_MARK_STACK]:
* xfns.c (clean_up_file_dialog):
* xmenu.c (cleanup_widget_value_tree):
Omit casts between XSAVE_POINTER and a pointer type.

diff --git a/src/ChangeLog b/src/ChangeLog
index 2445027edd529166bb87aa1b47e70593a2db06f2..80f5875ef166dc70c814432b264e160c0c2c56d3 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,18 @@
+2013-01-14  Paul Eggert  <eggert@cs.ucla.edu>
+
+       Avoid needless casts with XSAVE_POINTER.
+       * alloc.c (mark_object) [GC_MARK_STACK]:
+       * dired.c (directory_files_internal_unwind):
+       * fileio.c (do_auto_save_unwind):
+       * gtkutil.c (pop_down_dialog):
+       * keymap.c (map_keymap_char_table_item):
+       * lread.c (load_unwind):
+       * nsmenu.m (pop_down_menu):
+       * print.c (print_object) [GC_MARK_STACK]:
+       * xfns.c (clean_up_file_dialog):
+       * xmenu.c (cleanup_widget_value_tree):
+       Omit casts between XSAVE_POINTER and a pointer type.
+
 2013-01-14  Dmitry Antipov  <dmantipov@yandex.ru>
 
        Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE.

diff --git a/src/alloc.c b/src/alloc.c
index c50bb0f32c7484cd74bf956d5056a166d479cb4e..3f1ccc82a58a898b1da97970e3185721d2a21fa7 100644 (file)
--- a/src/alloc.c
+++ b/src/alloc.c
@@ -5943,7 +5943,7 @@ mark_object (Lisp_Object arg)
 #if GC_MARK_STACK
            if (ptr->area)
              {
-               Lisp_Object *p = (Lisp_Object *) ptr->data[0].pointer;
+               Lisp_Object *p = ptr->data[0].pointer;
                ptrdiff_t nelt;
                for (nelt = ptr->data[1].integer; nelt > 0; nelt--, p++)
                  mark_maybe_object (*p);

diff --git a/src/dired.c b/src/dired.c
index 77e89c6e6b3256a3d22dd7880b6e76320642f6db..8483721401ad6d839ea35ba7bde345bad03d1878 100644 (file)
--- a/src/dired.c
+++ b/src/dired.c
@@ -78,7 +78,7 @@ directory_files_internal_w32_unwind (Lisp_Object arg)
 static Lisp_Object
 directory_files_internal_unwind (Lisp_Object dh)
 {
-  DIR *d = (DIR *) XSAVE_POINTER (dh);
+  DIR *d = XSAVE_POINTER (dh);
   block_input ();
   closedir (d);
   unblock_input ();

diff --git a/src/fileio.c b/src/fileio.c
index 67b4b884bc08aba827b26fbe8347c290d1e7fbe4..d468576d63907672af42f3c7357a0b5a6568c00c 100644 (file)
--- a/src/fileio.c
+++ b/src/fileio.c
@@ -5507,7 +5507,7 @@ static Lisp_Object
 do_auto_save_unwind (Lisp_Object arg)  /* used as unwind-protect function */
 
 {
-  FILE *stream = (FILE *) XSAVE_POINTER (arg);
+  FILE *stream = XSAVE_POINTER (arg);
   auto_saving = 0;
   if (stream != NULL)
     {

diff --git a/src/gtkutil.c b/src/gtkutil.c
index 3b1bbc73cffb0b82577a4a383b65d092c4ec6326..259e0e971fd3eec5f0b979944dcf267da91073e6 100644 (file)
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -1650,7 +1650,7 @@ xg_dialog_response_cb (GtkDialog *w,
 static Lisp_Object
 pop_down_dialog (Lisp_Object arg)
 {
-  struct xg_dialog_data *dd = (struct xg_dialog_data *) XSAVE_POINTER (arg);
+  struct xg_dialog_data *dd = XSAVE_POINTER (arg);
 
   block_input ();
   if (dd->w) gtk_widget_destroy (dd->w);

diff --git a/src/keymap.c b/src/keymap.c
index 7b5aa45ebf37bc6f17d3a9836ceaff63916aa000..82c9e980221a6ee7b5d10d47eacd080bea3e276b 100644 (file)
--- a/src/keymap.c
+++ b/src/keymap.c
@@ -565,8 +565,7 @@ map_keymap_char_table_item (Lisp_Object args, Lisp_Object key, Lisp_Object val)
 {
   if (!NILP (val))
     {
-      map_keymap_function_t fun
-       = (map_keymap_function_t) XSAVE_POINTER (XCAR (args));
+      map_keymap_function_t fun = XSAVE_POINTER (XCAR (args));
       args = XCDR (args);
       /* If the key is a range, make a copy since map_char_table modifies
         it in place.  */

diff --git a/src/lread.c b/src/lread.c
index 35b61cbad4d533880e49b78bfb005e1710a7aa66..ced690a77b062732d04cfe983f49e9d1db3a5ab5 100644 (file)
--- a/src/lread.c
+++ b/src/lread.c
@@ -1357,7 +1357,7 @@ Return t if the file exists and loads successfully.  */)
 static Lisp_Object
 load_unwind (Lisp_Object arg)  /* Used as unwind-protect function in load.  */
 {
-  FILE *stream = (FILE *) XSAVE_POINTER (arg);
+  FILE *stream = XSAVE_POINTER (arg);
   if (stream != NULL)
     {
       block_input ();

diff --git a/src/nsmenu.m b/src/nsmenu.m
index 4e81b3201c88ae1fc2cac73cbbe386e0c9fb432e..3e6fa54b0477941615fc75cdae0e7e5256e32dba 100644 (file)
--- a/src/nsmenu.m
+++ b/src/nsmenu.m
@@ -1347,7 +1347,7 @@ struct Popdown_data
 static Lisp_Object
 pop_down_menu (Lisp_Object arg)
 {
-  struct Popdown_data *unwind_data = (struct Popdown_data *) XSAVE_POINTER (arg);
+  struct Popdown_data *unwind_data = XSAVE_POINTER (arg);
 
   block_input ();
   if (popup_activated_flag)

diff --git a/src/print.c b/src/print.c
index 0ae83cdf6d208df700216c2f9bd5cdca367e3b2a..2d96202f3893000383c7562fcbc61f7a85e83983 100644 (file)
--- a/src/print.c
+++ b/src/print.c
@@ -2054,7 +2054,7 @@ print_object (Lisp_Object obj, register Lisp_Object printcharfun, int escapeflag
                   normal circumstances.  */
 
                int limit = min (amount, 8);
-               Lisp_Object *area = (Lisp_Object *) v->data[0].pointer;
+               Lisp_Object *area = v->data[0].pointer;
 
                i = sprintf (buf, "with %"pD"d objects", amount);
                strout (buf, i, i, printcharfun);

diff --git a/src/xfns.c b/src/xfns.c
index 245ffae357359ca6f9398b86281f4456e324df98..fe99d36f9f44633073cc40cb50967072df362728 100644 (file)
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -5292,7 +5292,7 @@ file_dialog_unmap_cb (Widget widget, XtPointer client_data, XtPointer call_data)
 static Lisp_Object
 clean_up_file_dialog (Lisp_Object arg)
 {
-  Widget dialog = (Widget) XSAVE_POINTER (arg);
+  Widget dialog = XSAVE_POINTER (arg);
 
   /* Clean up.  */
   block_input ();

diff --git a/src/xmenu.c b/src/xmenu.c
index cbb5a3dc77eeab0d81d30785f0cf72e8700e60ce..6d880993d19b957bc95236e240624ce18653c6af 100644 (file)
--- a/src/xmenu.c
+++ b/src/xmenu.c
@@ -1610,7 +1610,7 @@ create_and_show_popup_menu (FRAME_PTR f, widget_value *first_wv,
 static Lisp_Object
 cleanup_widget_value_tree (Lisp_Object arg)
 {
-  free_menubar_widget_value_tree ((widget_value *) XSAVE_POINTER (arg));
+  free_menubar_widget_value_tree (XSAVE_POINTER (arg));
   return Qnil;
 }