]> git.eshelyaron.com Git - emacs.git/commitdiff
* bookmark.el: Define a face to highlight bookmark names in
authorKarl Fogel <kfogel@red-bean.com>
Thu, 7 Mar 2013 22:35:47 +0000 (16:35 -0600)
committerKarl Fogel <kfogel@red-bean.com>
Thu, 7 Mar 2013 22:35:47 +0000 (16:35 -0600)
bookmark menu buffers, where the default is a bold face similarly
to buffer names in buffer menu buffers.  Patch by Matthias Meulien
<orontee {_AT_} gmail.com>.

(bookmark-menu-bookmark): New face to highlight bookmark names.
(bookmark-insert-location): Removes dupplicated text property to
conform to buffer list (see `list-buffers')
(bookmark-bmenu-list, bookmark-bmenu-hide-filenames): Apply face
`bookmark-menu-bookmark' to bookmark names.

lisp/ChangeLog
lisp/bookmark.el

index f1ca958044b6d5df1cbde6a4b1511ee1704aa13a..4f24f5b2c8cd34080250138ddf12d61cb7e7d146 100644 (file)
@@ -1,3 +1,16 @@
+2013-03-07  Karl Fogel  <kfogel@red-bean.com>
+
+       * bookmark.el: Define a face to highlight bookmark names in
+       bookmark menu buffers, where the default is a bold face similarly
+       to buffer names in buffer menu buffers.  Patch by Matthias Meulien
+       <orontee {_AT_} gmail.com>.
+
+       (bookmark-menu-bookmark): New face to highlight bookmark names.
+       (bookmark-insert-location): Remove duplicated text property to
+       conform to buffer list (see `list-buffers').
+       (bookmark-bmenu-list, bookmark-bmenu-hide-filenames): Apply face
+       `bookmark-menu-bookmark' to bookmark names.
+
 2013-03-07  Karl Fogel  <kfogel@red-bean.com>
 
        * bookmark.el: Display the bookmark list header similarly to the
index fd6ae217bf80c13dff5f3ff59d471a088e2c643d..47e137996256f131b7083651f43b11af1b215984 100644 (file)
@@ -156,6 +156,10 @@ A non-nil value may result in truncated bookmark names."
   :type 'boolean
   :group 'bookmark)
 
+(defface bookmark-menu-bookmark
+  '((t (:weight bold)))
+  "Face used to highlight bookmark names in bookmark menu buffers."
+  :group 'bookmark)
 
 (defcustom bookmark-menu-length 70
   "Maximum length of a bookmark name displayed on a popup menu."
@@ -1182,18 +1186,7 @@ Optional second arg NO-HISTORY means don't record this in the
 minibuffer history list `bookmark-history'."
   (interactive (list (bookmark-completing-read "Insert bookmark location")))
   (or no-history (bookmark-maybe-historicize-string bookmark-name))
-  (let ((start (point)))
-    (prog1
-       (insert (bookmark-location bookmark-name))
-      (if (display-mouse-p)
-         (add-text-properties
-          start
-          (save-excursion (re-search-backward
-                           "[^ \t]")
-                           (1+ (point)))
-          '(mouse-face highlight
-            follow-link t
-            help-echo "mouse-2: go to this bookmark in other window"))))))
+  (insert (bookmark-location bookmark-name)))
 
 ;;;###autoload
 (defalias 'bookmark-locate 'bookmark-insert-location)
@@ -1578,7 +1571,8 @@ deletion, or > if it is flagged for displaying."
         (when (display-mouse-p)
           (add-text-properties
            (+ bookmark-bmenu-marks-width start) end
-           '(mouse-face highlight
+           '(font-lock-face bookmark-menu-bookmark
+            mouse-face highlight
              follow-link t
              help-echo "mouse-2: go to this bookmark in other window")))
         (insert "\n")))
@@ -1726,8 +1720,9 @@ mainly for debugging, and should not be necessary in normal use."
              (if (display-mouse-p)
                  (add-text-properties
                   start (point)
-                  '(mouse-face
-                    highlight follow-link t help-echo
+                  '(font-lock-face bookmark-menu-bookmark
+                   mouse-face highlight
+                   follow-link t help-echo
                     "mouse-2: go to this bookmark in other window"))))
            (forward-line 1)))))))