]> git.eshelyaron.com Git - emacs.git/commitdiff
Don't pass a constant as the state
authorNoam Postavsky <npostavs@gmail.com>
Sun, 24 Apr 2016 14:31:23 +0000 (10:31 -0400)
committerNoam Postavsky <npostavs@gmail.com>
Mon, 18 Jul 2016 02:26:40 +0000 (22:26 -0400)
for use-package-process-keywords, because the function may modify the
list object.  Modifying a quoted constant can lead to unexpected side
effects (e.g. values from previous use-package forms end up in
subsequent ones).

lisp/use-package/use-package.el

index cdff6ce772efe9f1bebce62bbf5ea8b33cc563a7..ffe2dac3e46f9919834c7d7470d6b58eaec344dd 100644 (file)
@@ -1167,7 +1167,7 @@ this file.  Usage:
       (let ((body
              (macroexp-progn
               (use-package-process-keywords name args*
-                (and use-package-always-defer '(:deferred t))))))
+                (and use-package-always-defer (list :deferred t))))))
         (if use-package-debug
             (display-buffer
              (save-current-buffer