]> git.eshelyaron.com Git - emacs.git/commitdiff
* lisp/icomplete.el (icomplete-fido-kill): Unbreak yes-or-no-p usage
authorJoão Távora <joaotavora@gmail.com>
Tue, 19 Nov 2019 23:53:10 +0000 (23:53 +0000)
committerJoão Távora <joaotavora@gmail.com>
Tue, 19 Nov 2019 23:55:54 +0000 (23:55 +0000)
Discussed in the context of bug#19064, bug#17272.

lisp/icomplete.el

index 8410ca5c3e16234c293f21131547381179ca74c9..16167ea21e19eebb05e9f9a036ae6e070101d00e 100644 (file)
@@ -253,7 +253,11 @@ require user confirmation."
                           (path (expand-file-name thing dir)))
                      (when (yes-or-no-p (concat "Delete file " path "? "))
                        (delete-file path) t)))))))
-        (when (funcall action)
+        (when (let (;; Allow `yes-or-no-p' to work and don't let it
+                    ;; `icomplete-exhibit' anything.
+                    (enable-recursive-minibuffers t)
+                    (icomplete-mode nil))
+                (funcall action))
           (completion--cache-all-sorted-completions
            (icomplete--field-beg)
            (icomplete--field-end)