]> git.eshelyaron.com Git - emacs.git/commitdiff
Don't allow functions that display messages in unsafep.
authorChong Yidong <cyd@stupidchicken.com>
Mon, 18 Oct 2010 17:28:20 +0000 (13:28 -0400)
committerChong Yidong <cyd@stupidchicken.com>
Mon, 18 Oct 2010 17:28:20 +0000 (13:28 -0400)
* emacs-lisp/unsafep.el: Don't mark functions that display
messages as safe.  Suggested by Johan Bockgård.

lisp/ChangeLog
lisp/emacs-lisp/unsafep.el

index 7c560c33b9d75ca5adf17031192a903adcf00c49..eb26c3923bfbfcf73189c644f626a38aca6178db 100644 (file)
@@ -1,3 +1,8 @@
+2010-10-18  Chong Yidong  <cyd@stupidchicken.com>
+
+       * emacs-lisp/unsafep.el: Don't mark functions that display
+       messages as safe.  Suggested by Johan Bockgård.
+
 2010-10-17  Stefan Monnier  <monnier@iro.umontreal.ca>
 
        * minibuffer.el (completion--replace): Move point where it belongs
index 851a1f7652ba3407f4ba8cbf0dc3ba0f38ba4e9f..a62f8de4010c95f1f371ac3dbb6b32b0eeeea8ef 100644 (file)
@@ -101,15 +101,13 @@ in the parse.")
 (dolist (x '(;;Special forms
             and catch if or prog1 prog2 progn while unwind-protect
             ;;Safe subrs that have some side-effects
-            ding error message minibuffer-message random read-minibuffer
-            signal sleep-for string-match throw y-or-n-p yes-or-no-p
+            ding error random signal sleep-for string-match throw
             ;;Defsubst functions from subr.el
             caar cadr cdar cddr
             ;;Macros from subr.el
-            save-match-data unless when with-temp-message
+            save-match-data unless when
             ;;Functions from subr.el that have side effects
-            read-passwd split-string replace-regexp-in-string
-            play-sound-file))
+            split-string replace-regexp-in-string play-sound-file))
   (put x 'safe-function t))
 
 ;;;###autoload