]> git.eshelyaron.com Git - emacs.git/commitdiff
(thumbs-call-convert): Use call-process directly
authorNick Roberts <nickrob@snap.net.nz>
Fri, 28 Dec 2007 08:09:57 +0000 (08:09 +0000)
committerNick Roberts <nickrob@snap.net.nz>
Fri, 28 Dec 2007 08:09:57 +0000 (08:09 +0000)
with thumbs-conversion-program instead of through shell-file-name
for better error reporting when program is missing.

lisp/thumbs.el

index 9d8b289cbe99da6970b66dc9dbf7093029ce17dc..395145fd53b4992fab4f4dceb96588a965dd680c 100644 (file)
@@ -248,15 +248,12 @@ ARG any arguments to the ACTION command,
 OUTPUT-FORMAT is the file format to output (default is jpeg),
 ACTION-PREFIX is the symbol to place before the ACTION command
               (defaults to '-' but can sometimes be '+')."
-  (let ((command (format "%s %s%s %s \"%s\" \"%s:%s\""
-                        thumbs-conversion-program
-                        (or action-prefix "-")
-                        action
-                        (or arg "")
-                        filein
-                        (or output-format "jpeg")
-                        fileout)))
-    (call-process shell-file-name nil nil nil shell-command-switch command)))
+  (call-process thumbs-conversion-program nil nil nil
+               (or action-prefix "-")
+               action
+               (or arg "")
+               filein
+               (format "%s:%s" (or output-format "jpeg") fileout)))
 
 (defun thumbs-new-image-size (s increment)
   "New image (a cons of width x height)."