]> git.eshelyaron.com Git - emacs.git/commitdiff
Make `nil' values of the `:position' underline property work correctly
authorPo Lu <luangruo@yahoo.com>
Thu, 20 Jan 2022 05:06:51 +0000 (13:06 +0800)
committerPo Lu <luangruo@yahoo.com>
Thu, 20 Jan 2022 05:06:51 +0000 (13:06 +0800)
* src/xfaces.c (Finternal_set_lisp_face_attribute): Handle cases
where the underline property `:position' is nil.

src/xfaces.c

index e148b5d3987fd1794ed84a2231e553ab7106c344..6a279f87192e4b00c6f02cbc45d6fbd9bf264e64 100644 (file)
@@ -3165,14 +3165,15 @@ FRAME 0 means change the face on all frames, and change the default
           */
           valid_p = true;
 
-          while (!NILP (CAR_SAFE(list)))
+          while (!NILP (CAR_SAFE (list)))
             {
               key = CAR_SAFE (list);
               list = CDR_SAFE (list);
               val = CAR_SAFE (list);
               list = CDR_SAFE (list);
 
-              if (NILP (key) || NILP (val))
+              if (NILP (key) || (NILP (val)
+                                && !EQ (key, QCposition)))
                 {
                   valid_p = false;
                   break;