Don't overwrite the link text in shr-tag-a for suspicious URLs

* lisp/net/shr.el (shr-tag-a): Tweak how the suspiciousness
warning is handled.

diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index 3ace872474cf96615f133b339185fd8c99edf982..c3950acd3d8f889fe6e826668b5cd3e83edcd883 100644 (file)
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1468,11 +1468,11 @@ ones, in case fg and bg are nil."
       (push (cons id (point)) shr--link-targets))
     (when url
       (shr-urlify (or shr-start start) (shr-expand-url url) title)
+      ;; Check whether the URL is suspicious.
       (when-let ((warning (textsec-check (shr-expand-url url) 'url)))
         (add-text-properties (or shr-start start) (point)
-                             (list 'help-echo warning
-                                   'face '(shr-link textsec-suspicious)))
-        (insert "⚠️")))))
+                             (list 'face '(shr-link textsec-suspicious)))
+        (insert (propertize "⚠️" 'help-echo warning))))))
 
 (defun shr-tag-abbr (dom)
   (let ((title (dom-attr dom 'title))