]> git.eshelyaron.com Git - emacs.git/commitdiff
test/eieio: Silence warnings about slots and obsolete name arg
authorStefan Monnier <monnier@iro.umontreal.ca>
Mon, 7 Apr 2025 03:49:37 +0000 (23:49 -0400)
committerEshel Yaron <me@eshelyaron.com>
Tue, 8 Apr 2025 05:49:53 +0000 (07:49 +0200)
* test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el
(eieio-test-method-order-list-3, eieio-test-method-order-list-6)
(eieio-test-method-order-list-7, eieio-test-method-order-list-8):
Delete obsolete name argument to constructors.
(eieio-test-method-order-list-4): Make sure backward compatibility is
active when testing the obsolete name arg.

* test/lisp/jsonrpc-tests.el (jsonrpc--call-with-emacsrpc-fixture):
Delete obsolete name argument to constructor.

* test/lisp/emacs-lisp/eieio-tests/eieio-tests.el (derived-value):
Silence unknown slot warning.

(cherry picked from commit 31c5fd3bfba31687de31e1e4c3d3501401f023bc)

test/lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el
test/lisp/emacs-lisp/eieio-tests/eieio-tests.el
test/lisp/jsonrpc-tests.el

index c9da7d92deb77229026f188c50bbd59d5003a069..13c33a219ee4511d07eb535cc52ac92b9d62e368 100644 (file)
               (:AFTER eitest-B-base1)
               (:AFTER eitest-B)
               )))
-    (eitest-F (eitest-B nil))
+    (eitest-F (eitest-B))
     (setq eieio-test-method-order-list (nreverse eieio-test-method-order-list))
     (eieio-test-match ans)))
 
 (ert-deftest eieio-test-method-order-list-4 ()
   ;; Both of these situations should succeed.
   (should (eitest-H 'eitest-A))
-  (should (eitest-H (eitest-A nil))))
+  (let ((eieio-backward-compatibility t))
+    (with-suppressed-warnings ((obsolete eieio-constructor-name-arg))
+      (should (eitest-H (eitest-A nil))))))
 
 ;;; Return value from :PRIMARY
 ;;
               (:STATIC C-base1)
               (:STATIC C-base2)
               )))
-    (C nil)
+    (C)
     (setq eieio-test-method-order-list (nreverse eieio-test-method-order-list))
     (eieio-test-match ans)))
 
               (:PRIMARY D-base2)
               (:PRIMARY D-base0)
               )))
-    (eitest-F (D nil))
+    (eitest-F (D))
     (setq eieio-test-method-order-list (nreverse eieio-test-method-order-list))
     (eieio-test-match ans)))
 
               (:PRIMARY E-base2)
               (:PRIMARY E-base0)
               )))
-    (eitest-F (E nil))
+    (eitest-F (E))
     (setq eieio-test-method-order-list (nreverse eieio-test-method-order-list))
     (eieio-test-match ans)))
 
index 51996fe51bec3c2557a39683747600b50c0589d4..fced6bc3df24483b98b77682efb28794db5eda4e 100644 (file)
@@ -430,6 +430,9 @@ METHOD is the method that was attempting to be called."
 (defclass virtual-slot-class ()
   ((base-value :initarg :base-value))
   "Class has real slot :base-value and simulated slot :derived-value.")
+
+(eieio-declare-slots derived-value)
+
 (with-suppressed-warnings ((obsolete defmethod)
                            (obsolete defgeneric))
   (defmethod slot-missing ((vsc virtual-slot-class)
index 68eaae6c44b745b4a855d2266e1a7a2c631299ae..148f5870434127a349068eb91831258f4bdfdacb 100644 (file)
@@ -76,7 +76,6 @@
           (setq endpoint
                 (make-instance
                  'jsonrpc--test-client
-                 "Emacs RPC client"
                  :process
                  (open-network-stream "JSONRPC test tcp endpoint"
                                       nil "localhost"