]> git.eshelyaron.com Git - emacs.git/commitdiff
* lisp/minibuffer.el (minibuffer-completion-help): Specify the end of the
authorStefan Monnier <monnier@iro.umontreal.ca>
Mon, 8 Nov 2010 20:53:42 +0000 (15:53 -0500)
committerStefan Monnier <monnier@iro.umontreal.ca>
Mon, 8 Nov 2010 20:53:42 +0000 (15:53 -0500)
completion field.

Fixes: debbugs:7211
lisp/ChangeLog
lisp/minibuffer.el

index 0a38a9a6c9f0fb3e61e71e0d07a667d9e5400f35..f170bda4fab75466ed7fc8f7e9bc0e7c8c8bb176 100644 (file)
@@ -1,5 +1,8 @@
 2010-11-08  Stefan Monnier  <monnier@iro.umontreal.ca>
 
+       * minibuffer.el (minibuffer-completion-help): Specify the end of the
+       completion field (bug#7211).
+
        * progmodes/python.el (python-font-lock-syntactic-keywords): (bug#7322)
        Fix handling of backslash escapes.
        (python-quote-syntax): Adjust accordingly.
index bc5a1d2e8071c114d10b74a044960a042c1e9810..006e873ac5707d220d8a67f1e29c254d56c9f12e 100644 (file)
@@ -41,7 +41,7 @@
 ;;   provide the start info but not the end info in
 ;;   completion-base-position.
 ;; - quoting is problematic.  E.g. the double-dollar quoting used in
-;;   substitie-in-file-name (and hence read-file-name-internal) bumps
+;;   substitute-in-file-name (and hence read-file-name-internal) bumps
 ;;   into various bugs:
 ;; - choose-completion doesn't know how to quote the text it inserts.
 ;;   E.g. it fails to double the dollars in file-name completion, or
@@ -1075,6 +1075,7 @@ variables.")
   (interactive)
   (message "Making completion list...")
   (lexical-let* ((start (field-beginning))
+                 (end (field-end))
                 (string (field-string))
                 (completions (completion-all-completions
                               string
@@ -1106,10 +1107,12 @@ variables.")
                             completions)))
             (with-current-buffer standard-output
               (set (make-local-variable 'completion-base-position)
-                   ;; FIXME: We should provide the END part as well, but
-                   ;; currently completion-all-completions does not give
-                   ;; us the necessary information.
-                   (list (+ start base-size) nil)))
+                   (list (+ start base-size)
+                         ;; FIXME: We should pay attention to completion
+                         ;; boundaries here, but currently
+                         ;; completion-all-completions does not give us the
+                         ;; necessary information.
+                         end)))
             (display-completion-list completions)))
 
       ;; If there are no completions, or if the current input is already the