(dired-format-columns-of-files): Use completion--insert-strings.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 6405f47dece2e853f4026aec362113e3dee318ef..1177b89449a0404694964c57104e6f404c726916 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -5,6 +5,7 @@
 
        * dired.el (dired-read-dir-and-switches):
        Set minibuffer-completing-file-name and call substitute-in-file-name.
+       (dired-format-columns-of-files): Use completion--insert-strings.
 
        * minibuffer.el (completion-hilit-commonality): Revert last change:
        the leftover code was actually useful.

diff --git a/lisp/dired.el b/lisp/dired.el
index a2f0f009d33f9e5fbae17c35c3753fd4e57613b0..51dc58167b508b0c86a833ccf3c9bb7fd7c634a0 100644 (file)
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -2708,31 +2708,9 @@ just the current file."
       (apply function args))))
 
 (defun dired-format-columns-of-files (files)
-  ;; Files should be in forward order for this loop.
-  ;; i.e., (car files) = first file in buffer.
-  ;; Returns the number of lines used.
-  (let* ((maxlen (+ 2 (apply 'max (mapcar 'length files))))
-        (width (- (window-width (selected-window)) 2))
-        (columns (max 1 (/ width maxlen)))
-        (nfiles (length files))
-        (rows (+ (/ nfiles columns)
-                 (if (zerop (% nfiles columns)) 0 1)))
-        (i 0)
-        (j 0))
-    (setq files (nconc (copy-sequence files) ; fill up with empty fns
-                      (make-list (- (* columns rows) nfiles) "")))
-    (setcdr (nthcdr (1- (length files)) files) files) ; make circular
-    (while (< j rows)
-      (while (< i columns)
-       (indent-to (* i maxlen))
-       (insert (car files))
-       (setq files (nthcdr rows files)
-             i (1+ i)))
-      (insert "\n")
-      (setq i 0
-           j (1+ j)
-           files (cdr files)))
-    rows))
+  (let ((beg (point)))
+    (completion--insert-strings files)
+    (put-text-property beg (point) 'mouse-face nil)))
 \f
 ;; Commands to mark or flag file(s) at or near current line.