* nsfont.m (ns_has_attribute): Remove. (ns_findfonts, nsfont_open): Use ns_attribute...

diff --git a/src/ChangeLog b/src/ChangeLog
index 499873f5a1967d1aef8a4b7ae64887fedb7890f7..51a7c7bafbe537e785c11fbbc0e8d3855d212314 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2009-07-14  Adrian Robert  <Adrian.B.Robert@gmail.com>
+
+       * nsfont.m (ns_has_attribute): Remove.
+       (ns_findfonts, nsfont_open): Use ns_attribute_fvalue() instead.
+
 2009-07-13  Kenichi Handa  <handa@m17n.org>
 
        * chartab.c (sub_char_table_ref_and_range): Fix the range check

diff --git a/src/nsfont.m b/src/nsfont.m
index 68ed1e6dd360f3a91afa97f3b350900d2c1405f4..e920ce9bc76a02d72f2248e9dc8e46c06344430a 100644 (file)
--- a/src/nsfont.m
+++ b/src/nsfont.m
@@ -119,15 +119,6 @@ ns_attribute_fvalue (NSFontDescriptor *fdesc, NSString *trait)
 }
 
 
-/* Return whether font has attribute set to non-standard value. */
-static BOOL
-ns_has_attribute (NSFontDescriptor *fdesc, NSString *trait)
-{
-    float v = ns_attribute_fvalue (fdesc, trait);
-    return v < -0.05 || v > 0.05;
-}
-
-
 /* Converts FONT_WEIGHT, FONT_SLANT, FONT_WIDTH, plus family and script/lang
    to NSFont descriptor.  Information under extra only needed for matching. */
 #define STYLE_REF 100
@@ -490,7 +481,7 @@ ns_findfonts (Lisp_Object font_spec, BOOL isMatch)
        list = Fcons (ns_descriptor_to_entity (desc,
                                         AREF (font_spec, FONT_EXTRA_INDEX),
                                         NULL), list);
-       if (ns_has_attribute (desc, NSFontSlantTrait))
+       if (fabs (ns_attribute_fvalue (desc, NSFontSlantTrait)) > 0.05)
            foundItal = YES;
       }
 
@@ -666,9 +657,11 @@ nsfont_open (FRAME_PTR f, Lisp_Object font_entity, int pixel_size)
   synthItal = !NILP (tem) && !strncmp ("synthItal", SDATA (SYMBOL_NAME (tem)),
                                        9);
   family = ns_get_family (font_entity);
-  if (ns_has_attribute (fontDesc, NSFontWeightTrait))
+  /* Should be > 0.23 as some font descriptors (e.g. Terminus) set to that
+     when setting family in ns_spec_to_descriptor(). */
+  if (ns_attribute_fvalue (fontDesc, NSFontWeightTrait) > 0.50)
       traits |= NSBoldFontMask;
-  if (ns_has_attribute (fontDesc, NSFontSlantTrait))
+  if (fabs (ns_attribute_fvalue (fontDesc, NSFontSlantTrait) > 0.05))
       traits |= NSItalicFontMask;
 
   /* see http://cocoadev.com/forums/comments.php?DiscussionID=74 */