Fix use of deallocated memory.

* nsterm.h (EmacsScroller): Remove dealloc.

* nsterm.m (judge): EmacsScroller: Move dealloc code here.
(dealloc): Remove for EmacsScroller.

diff --git a/src/ChangeLog b/src/ChangeLog
index ad34152d1a3b4660ba1edbdb107c3b30e3c0c5cf..17dbd106df37ed2d40fc41c3b0e71b6a654e9a0a 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,10 @@
+2014-06-30  Jan Djärv  <jan.h.d@swipnet.se>
+
+       * nsterm.m (judge): EmacsScroller: Move dealloc code here.
+       (dealloc): Remove for EmacsScroller.
+
+       * nsterm.h (EmacsScroller): Remove dealloc.
+
 2014-06-30  Eli Zaretskii  <eliz@gnu.org>
 
        * coding.c (MIN_CHARBUF_SIZE): Enlarge to 32.  (Bug#17881)

diff --git a/src/nsterm.h b/src/nsterm.h
index e77aca3d50d263e84c3ea1c5a377669be2f28637..2619b7100733ac8869e8d23ff0b8526d641d25b2 100644 (file)
--- a/src/nsterm.h
+++ b/src/nsterm.h
@@ -412,7 +412,6 @@ typedef float EmacsCGFloat;
 
 - initFrame: (NSRect )r window: (Lisp_Object)win;
 - (void)setFrame: (NSRect)r;
-- (void)dealloc;
 
 - setPosition: (int) position portion: (int) portion whole: (int) whole;
 - (int) checkSamePosition: (int)position portion: (int)portion

diff --git a/src/nsterm.m b/src/nsterm.m
index 69738ba924ab6221ddcb88df64745bb0db02b2e7..f2eeeda93bf169eec752f6c7544caca4cd72bd4c 100644 (file)
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -7144,15 +7144,6 @@ if (cols > 0 && rows > 0)
 }
 
 
-- (void)dealloc
-{
-  NSTRACE (EmacsScroller_dealloc);
-  if (!NILP (win))
-    wset_vertical_scroll_bar (XWINDOW (win), Qnil);
-  [super dealloc];
-}
-
-
 - condemn
 {
   NSTRACE (condemn);
@@ -7180,6 +7171,9 @@ if (cols > 0 && rows > 0)
       view = (EmacsView *)FRAME_NS_VIEW (frame);
       if (view != nil)
         view->scrollbarsNeedingUpdate++;
+      if (!NILP (win))
+        wset_vertical_scroll_bar (XWINDOW (win), Qnil);
+      win = Qnil;
       [self removeFromSuperview];
       [self release];
       unblock_input ();