]> git.eshelyaron.com Git - emacs.git/commitdiff
Restore antlr-mode's intended mode-name construct fix/bug-2034
authorPhil Sainty <psainty@orcon.net.nz>
Sat, 7 Jul 2018 09:09:24 +0000 (21:09 +1200)
committerPhil Sainty <psainty@orcon.net.nz>
Sat, 7 Jul 2018 13:20:10 +0000 (01:20 +1200)
* lisp/progmodes/antlr-mode.el (antlr-mode): Restore antlr-mode's
intended mode-name, as CC mode now supports arbitrary mode line
constructs.

Note that the NAME supplied to 'define-derived-mode' should be a
string, so the original (commented) code wasn't quite right.

lisp/progmodes/antlr-mode.el

index 775fd8787258cf087b515f9823be4d9aaedf8afd..ad6d45e0b4c99b7d818dd995079e8571b8b248c4 100644 (file)
@@ -2553,11 +2553,7 @@ the default language."
     (car r)))
 
 ;;;###autoload
-(define-derived-mode antlr-mode prog-mode
-  ;; FIXME: Since it uses cc-mode, it bumps into c-update-modeline's
-  ;; limitation to mode-name being a string.
-  ;; '("Antlr." (:eval (cadr (assq antlr-language antlr-language-alist))))
-  "Antlr"
+(define-derived-mode antlr-mode prog-mode "Antlr"
   "Major mode for editing ANTLR grammar files."
   :abbrev-table antlr-mode-abbrev-table
   (c-initialize-cc-mode)               ; cc-mode is required
@@ -2567,10 +2563,9 @@ the default language."
   (unless antlr-language
     (set (make-local-variable 'antlr-language)
          (or (antlr-language-option t) (antlr-language-option nil))))
-  (if (stringp (cadr (assq antlr-language antlr-language-alist)))
-      (setq mode-name
-           (concat "Antlr."
-                   (cadr (assq antlr-language antlr-language-alist)))))
+  (setq mode-name
+       '("Antlr." (:eval (cadr (assq antlr-language
+                                      antlr-language-alist)))))
   ;; indentation, for the C engine -------------------------------------------
   (setq c-buffer-is-cc-mode antlr-language)
   (cond ((fboundp 'c-init-language-vars-for) ; cc-mode 5.30.5+