]> git.eshelyaron.com Git - emacs.git/commitdiff
Add new option ruby-bracketed-args-indent
authorAaron Jensen <aaronjensen@gmail.com>
Sat, 31 Aug 2024 23:31:20 +0000 (19:31 -0400)
committerEshel Yaron <me@eshelyaron.com>
Sun, 8 Sep 2024 11:21:42 +0000 (13:21 +0200)
* lisp/progmodes/ruby-mode.el (ruby-bracketed-args-indent): New option.
(ruby-smie-rules): Use it (bug#60321).
* test/lisp/progmodes/ruby-mode-resources/ruby-bracketed-args-indent.rb:
New file.
* test/lisp/progmodes/ruby-mode-tests.el: Use it for new case.

(cherry picked from commit 6c15b7710d4bfc201afbafd2daec74c2baec9102)

lisp/progmodes/ruby-mode.el
test/lisp/progmodes/ruby-mode-resources/ruby-bracketed-args-indent.rb [new file with mode: 0644]
test/lisp/progmodes/ruby-mode-tests.el

index 3bcfa9ee7df2c07262af880522d203cba4c7864e..d953ec8b25c476d7ab1bb2db368ce170c7b4eede 100644 (file)
@@ -472,6 +472,26 @@ Only has effect when `ruby-use-smie' is t."
   :safe 'booleanp
   :version "29.1")
 
+(defcustom ruby-bracketed-args-indent t
+  "Non-nil to align the contents of bracketed arguments with the brackets.
+
+Example:
+
+  qux({
+        foo => bar
+      })
+
+Set it to nil to align to the beginning of the statement:
+
+  qux({
+    foo => bar
+  })
+
+Only has effect when `ruby-use-smie' is t."
+  :type 'boolean
+  :safe 'booleanp
+  :version "30.1")
+
 (defcustom ruby-deep-arglist t
   "Deep indent lists in parenthesis when non-nil.
 Also ignores spaces after parenthesis when `space'.
@@ -826,6 +846,9 @@ This only affects the output of the command `ruby-toggle-block'."
       ))
     (`(:before . ,(or "(" "[" "{"))
      (cond
+      ((and (not (eq ruby-bracketed-args-indent t))
+            (smie-rule-prev-p "," "(" "["))
+       (cons 'column (current-indentation)))
       ((and (equal token "{")
             (not (smie-rule-prev-p "(" "{" "[" "," "=>" "=" "return" ";" "do"))
             (save-excursion
diff --git a/test/lisp/progmodes/ruby-mode-resources/ruby-bracketed-args-indent.rb b/test/lisp/progmodes/ruby-mode-resources/ruby-bracketed-args-indent.rb
new file mode 100644 (file)
index 0000000..ac7a734
--- /dev/null
@@ -0,0 +1,32 @@
+update({
+  key => value,
+  other_key:
+}, {
+  key => value,
+  other_key:
+})
+
+update([
+  1,
+  2
+], [
+  3,
+  4
+])
+
+update([{
+  key: "value"
+}, {
+  key: "value"
+}])
+
+update(arg1, {
+  foo: "bar"
+}, [
+  1,
+  2
+], arg2)
+
+# Local Variables:
+# ruby-bracketed-args-indent: nil
+# End:
index 2b8506a7adcb80c50f3733dac485b6313b892205..c9cde791baae1c3556bbea9e1fdfb99ea6a2b85f 100644 (file)
@@ -992,6 +992,7 @@ VALUES-PLIST is a list with alternating index and value elements."
 (ruby-deftest-indent "ruby-method-call-indent.rb")
 (ruby-deftest-indent "ruby-method-params-indent.rb")
 (ruby-deftest-indent "ruby-parenless-call-arguments-indent.rb")
+(ruby-deftest-indent "ruby-bracketed-args-indent.rb")
 
 (ert-deftest ruby--test-chained-indentation ()
   (with-temp-buffer