Stricter check for string value in savehist-printable

Fixes: debbugs:10937

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index e21cf0b6bba7d64d3daa4604ce843a443a01dce7..3edff65044ab37853def6f0da5e0bea33ea0b5c6 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2012-03-09  Leo Liu  <sdl.web@gmail.com>
+
+       * savehist.el (savehist-printable): Stricter check for string
+       value (Bug#10937).
+
 2012-03-09  Eli Zaretskii  <eliz@gnu.org>
 
        * mail/smtpmail.el (smtpmail-send-it): Bind

diff --git a/lisp/savehist.el b/lisp/savehist.el
index c1515fa48ce7f1912be6407b3ea903d597ea3e2e..a65906a16765bf811886caaaf4b4bd13e6f79425 100644 (file)
--- a/lisp/savehist.el
+++ b/lisp/savehist.el
@@ -369,9 +369,11 @@ trimming of history lists to `history-length' items."
   "Return non-nil if VALUE is printable."
   (cond
    ;; Quick response for oft-encountered types known to be printable.
-   ((stringp value))
    ((numberp value))
    ((symbolp value))
+   ;; String without properties
+   ((and (stringp value)
+        (equal-including-properties value (substring-no-properties value))))
    (t
     ;; For others, check explicitly.
     (with-temp-buffer