* nsfont.m (nsfont_draw): Fix the references to missing gidx data

member to point to cmp_from.

* xdisp.c: Doc fix for references to gidx data member.

diff --git a/src/ChangeLog b/src/ChangeLog
index 96e1062af0dc09b4d37d6e239adbe00a6b058d0b..82f4c5ab555ae13ffd1487b3de0f05d7cd2a622a 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,10 @@
+2008-09-07  Teodor Zlatanov  <tzz@lifelogs.com>
+
+       * nsfont.m (nsfont_draw): Fix the references to missing gidx data
+       member to point to cmp_from.
+
+       * xdisp.c: Doc fix for references to gidx data member.
+
 2008-09-07  Stefan Monnier  <monnier@iro.umontreal.ca>
 
        * buffer.c (Fbuffer_swap_text): Reset window->point markers.

diff --git a/src/nsfont.m b/src/nsfont.m
index f49cd0ffbdadd79e66f8848156d434d15badcbd9..42507f08eacca529e53f6df0846ce0f0b7907087 100644 (file)
--- a/src/nsfont.m
+++ b/src/nsfont.m
@@ -904,14 +904,14 @@ nsfont_draw (struct glyph_string *s, int from, int to, int x, int y,
     int hi, lo;
     char isComposite = 0; /* s->first_glyph->type == COMPOSITE_GLYPH; */
     /* FIXME: composition: no vertical displacement is considered. */
-    t+= s->gidx; /* advance into composition */
-    for (i =0; i<s->nchars - s->gidx; i++, t++)
+    t+= s->cmp_from; /* advance into composition */
+    for (i =0; i<s->nchars - s->cmp_from; i++, t++)
       {
         hi = (*t & 0xFF00) >> 8;
         lo = *t & 0x00FF;
         if (isComposite)
           {
-            cwidth = s->cmp->offsets[s->gidx++ * 2] - twidth;
+            cwidth = s->cmp->offsets[s->cmp_from++ * 2] - twidth;
           }
         else
           {
@@ -1094,13 +1094,13 @@ nsfont_draw (struct glyph_string *s, int from, int to, int x, int y,
       [col set];
 
     CGContextSetTextPosition (gcontext, r.origin.x, r.origin.y);
-    CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->gidx,
+    CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->cmp_from,
                                     advances, len);
 
     if (face->overstrike)
       {
         CGContextSetTextPosition (gcontext, r.origin.x+0.5, r.origin.y);
-        CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->gidx,
+        CGContextShowGlyphsWithAdvances (gcontext, s->char2b + s->cmp_from,
                                         advances, len);
       }
 

diff --git a/src/xdisp.c b/src/xdisp.c
index 9e351b5c47da7ff492a089fbbf1bf8a2c99afca8..82c9e82effa0e527fff9bfc8c7e7a4f628a1a2a0 100644 (file)
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -19532,7 +19532,7 @@ get_glyph_face_and_encoding (f, glyph, char2b, two_byte_p)
 /* Fill glyph string S with composition components specified by S->cmp.
 
    BASE_FACE is the base face of the composition.
-   S->gidx is the index of the first component for S.
+   S->cmp_from is the index of the first component for S.
 
    OVERLAPS non-zero means S should draw the foreground only, and use
    its physical height for clipping.  See also draw_glyphs.
@@ -19547,7 +19547,7 @@ fill_composite_glyph_string (s, base_face, overlaps)
 {
   int i;
   /* For all glyphs of this composition, starting at the offset
-     S->gidx, until we reach the end of the definition or encounter a
+     S->cmp_from, until we reach the end of the definition or encounter a
      glyph that requires the different face, add it to S.  */
   struct face *face;