]> git.eshelyaron.com Git - emacs.git/commitdiff
Don't check comp-buffer-name-function in derived mode (Bug#34956)
authorTroy Hinckley <t.macman@gmail.com>
Wed, 16 Jan 2019 22:47:07 +0000 (14:47 -0800)
committerNoam Postavsky <npostavs@users.sourceforge.net>
Thu, 4 Apr 2019 23:39:42 +0000 (19:39 -0400)
* lisp/progmodes/compile.el (define-compilation-mode): Remove
'compilation-buffer-name-function' from the list of overridden
variables to ensure that it is not mistaken for a variable that can be
major mode specific.  'compilation-buffer-name-function' is used
before the major mode is loaded, therefore overriding it here is
ineffectual.  Also, the function 'compilation-start' takes an optional
argument name-function, so there is already a mechanism to override
it.

lisp/progmodes/compile.el

index 6d5775209c035b5c5a3a757d2ba38965a504ea81..1a0d9bdbb703bc79b54c99ce62b510d62568052b 100644 (file)
@@ -2056,8 +2056,7 @@ by replacing the first word, e.g., `compilation-scroll-output' from
                            (if (boundp 'byte-compile-bound-variables)
                                (memq (cdr v) byte-compile-bound-variables)))
                        `(set (make-local-variable ',(car v)) ,(cdr v))))
-                '(compilation-buffer-name-function
-                  compilation-directory-matcher
+                '(compilation-directory-matcher
                   compilation-error
                   compilation-error-regexp-alist
                   compilation-error-regexp-alist-alist