lisp/doc-view.el: Silence compiler warning.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index ed08474bdcb145cdd161026e5b4aa8ad78e89f01..91bf824092256e77755e50cc99dbbf16e88aac32 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2011-06-05  Juanma Barranquero  <lekktu@gmail.com>
+
+       * doc-view.el (doc-view-remove-if): Move computation of result out
+       of `dolist' to silence misleading lexical-binding warning.
+
 2011-06-04  Chong Yidong  <cyd@stupidchicken.com>
 
        * emacs-lisp/timer.el (timer-activate): Remove unused arg.

diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index 7bd1a55011e37e36fa96fc89aa857b98bfd2b548..06c3b70a3a6db529695e785169354c52d6867c54 100644 (file)
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -614,9 +614,10 @@ It's a subdirectory of `doc-view-cache-directory'."
 (defun doc-view-remove-if (predicate list)
   "Return LIST with all items removed that satisfy PREDICATE."
   (let (new-list)
-    (dolist (item list (nreverse new-list))
+    (dolist (item list)
       (when (not (funcall predicate item))
-       (setq new-list (cons item new-list))))))
+       (setq new-list (cons item new-list))))
+     (nreverse new-list)))
 
 ;;;###autoload
 (defun doc-view-mode-p (type)