* lisp/vc-dispatcher.el: Rename mode-line-hook to vc-mode-line-hook;

declare it, make it buffer-local, and permanent-local.
(vc-resynch-window): Adjust name.
* lisp/vc-hooks.el (vc-find-file-hook): Adjust name.

Fixes: debbugs:6324

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index a36b5be3f02b873303e5da254a196bbf0bcb2662..57115bba4000568661197120d718a3af7d099c7d 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,10 @@
+2010-06-09  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+       * vc-dispatcher.el: Rename mode-line-hook to vc-mode-line-hook;
+       declare it, make it buffer-local and permanent-local (bug#6324).
+       (vc-resynch-window): Adjust name.
+       * vc-hooks.el (vc-find-file-hook): Adjust name.
+
 2010-06-07  Jonathan Rockway  <jon@jrock.us>
 
        * net/rcirc.el: Add support for password authentication.

diff --git a/lisp/vc-dispatcher.el b/lisp/vc-dispatcher.el
index 40223c9010d01afc5716fc553c0487f79806fcd7..0c3820bc5298c692b2449383772e76f22799324a 100644 (file)
--- a/lisp/vc-dispatcher.el
+++ b/lisp/vc-dispatcher.el
@@ -101,7 +101,7 @@
 ;; that on-disk files and the contents of their visiting Emacs buffers
 ;; coincide.
 ;;
-;; When the client mode adds a local mode-line-hook to a buffer, it
+;; When the client mode adds a local vc-mode-line-hook to a buffer, it
 ;; will be called with the buffer file name as argument whenever the
 ;; dispatcher resynchs the buffer.
 
@@ -454,6 +454,10 @@ ARG and NO-CONFIRM are passed on to `revert-buffer'."
       (revert-buffer arg no-confirm t))
     (vc-restore-buffer-context context)))
 
+(defvar vc-mode-line-hook nil)
+(make-variable-buffer-local 'vc-mode-line-hook)
+(put 'vc-mode-line-hook 'permanent-local t)
+
 (defun vc-resynch-window (file &optional keep noquery)
   "If FILE is in the current buffer, either revert or unvisit it.
 The choice between revert (to see expanded keywords) and unvisit
@@ -479,7 +483,8 @@ editing!"
                          (not (eq (get major-mode 'mode-class) 'special))
                          (view-mode-enter))))
 
-            (run-hook-with-args 'mode-line-hook buffer-file-name))
+             ;; FIXME: Why use a hook?  Why pass it buffer-file-name?
+            (run-hook-with-args 'vc-mode-line-hook buffer-file-name))
         (kill-buffer (current-buffer)))))
 
 (declare-function vc-dir-resynch-file "vc-dir" (&optional fname))

diff --git a/lisp/vc-hooks.el b/lisp/vc-hooks.el
index 01c1dc822df54068ea102e997e34d420857b44a8..70369df06fe701e2f3029e005f728a3bc6b358dc 100644 (file)
--- a/lisp/vc-hooks.el
+++ b/lisp/vc-hooks.el
@@ -880,7 +880,8 @@ current, and kill the buffer that visits the link."
     (setq vc-mode nil))
   (when buffer-file-name
     (vc-file-clearprops buffer-file-name)
-    (add-hook 'mode-line-hook 'vc-mode-line nil t)
+    ;; FIXME: Why use a hook?  Why pass it buffer-file-name?
+    (add-hook 'vc-mode-line-hook 'vc-mode-line nil t)
     (let (backend)
       (cond
        ((setq backend (with-demoted-errors (vc-backend buffer-file-name)))