* lisp/emacs-lisp/timer.el (timer-event-handler): Don't retrigger a canceled

timer.

Fixes: debbugs:14156

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index a2be1055f4668b86b7a34fed77c2f73bb034041e..f5cf9d078e7d34d488cbc2ca3f61a1b43822d73e 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2013-04-08  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+       * emacs-lisp/timer.el (timer-event-handler): Don't retrigger a canceled
+       timer (bug#14156).
+
 2013-04-07  Nic Ferrier  <nferrier@ferrier.me.uk>
 
        * emacs-lisp/ert.el (should, should-not, should-error): Add edebug

diff --git a/lisp/emacs-lisp/timer.el b/lisp/emacs-lisp/timer.el
index 8b019d0a7855c042c895f4eecd7e9c51d050e2e4..8b1dca8cb784d107866ef7da4a8f15b8d86f474f 100644 (file)
--- a/lisp/emacs-lisp/timer.el
+++ b/lisp/emacs-lisp/timer.el
@@ -314,8 +314,12 @@ This function is called, by name, directly by the C code."
               (save-current-buffer
                 (apply (timer--function timer) (timer--args timer)))
            (error (message "Error in timer: %S" err)))
-         (if retrigger
-             (setf (timer--triggered timer) nil)))
+         (when (and retrigger
+                     ;; If the timer's been canceled, don't "retrigger" it
+                     ;; since it might still be in the copy of timer-list kept
+                     ;; by keyboard.c:timer_check (bug#14156).
+                     (memq timer timer-list))
+            (setf (timer--triggered timer) nil)))
       (error "Bogus timer event"))))
 
 ;; This function is incompatible with the one in levents.el.