Make "C-h o" show faces as well as variables

* lisp/faces.el (describe-face): Return (buffer-string).  Reorder
the placement of variables/faces in describe-symbol, to put more
emphasis on the variable entry rather than the face.  (Bug#24543)

diff --git a/lisp/faces.el b/lisp/faces.el
index c0c1c7b59f04106153ad73d1d5160e3968781b0b..5ed11d11cef689547609a78036fce1cb75bce718 100644 (file)
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -1454,7 +1454,7 @@ If FRAME is omitted or nil, use the selected frame."
        (setq face (list face)))
     (with-help-window (help-buffer)
       (with-current-buffer standard-output
-       (dolist (f face)
+       (dolist (f face (buffer-string))
          (if (stringp f) (setq f (intern f)))
          ;; We may get called for anonymous faces (i.e., faces
          ;; expressed using prop-value plists).  Those can't be

diff --git a/lisp/help-mode.el b/lisp/help-mode.el
index 3fb793e7aa5e521ab419c5d478eb17b29beb900c..24dfb9120bff94abd3ec90a4df725368cdbe5d34 100644 (file)
--- a/lisp/help-mode.el
+++ b/lisp/help-mode.el
@@ -393,12 +393,12 @@ it does not already exist."
 
 (defvar describe-symbol-backends
   `((nil ,#'fboundp ,(lambda (s _b _f) (describe-function s)))
-    ("face" ,#'facep ,(lambda (s _b _f) (describe-face s)))
     (nil
      ,(lambda (symbol)
         (or (and (boundp symbol) (not (keywordp symbol)))
             (get symbol 'variable-documentation)))
-     ,#'describe-variable)))
+     ,#'describe-variable)
+    ("face" ,#'facep ,(lambda (s _b _f) (describe-face s)))))
 
 ;;;###autoload
 (defun help-make-xrefs (&optional buffer)