Markus Triska <markus.triska at gmx.at>

(byte-compile-normal-call): Warn when `mapcar' is called for effect.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 0fdd025d0beaa0237f864fbce110ce12a701a3a5..f238531667afc64c9b589d7ae66ab397785e9629 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2007-09-21  Markus Triska  <markus.triska@gmx.at>
+
+       * emacs-lisp/bytecomp.el (byte-compile-normal-call): Warn when
+       `mapcar' is called for effect.
+
 2007-09-21  Glenn Morris  <rgm@gnu.org>
 
        * obsolete/sun-fns.el (emacs-quit-menu): Remove emacstool-related code.

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 2c14bb666097f4b5988afa137e9a1bf6910028b2..10b65d4c47e3b95daddb34f1899ca3246f8851b6 100644 (file)
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -2831,6 +2831,10 @@ That command is designed for interactive use only" fn))
 (defun byte-compile-normal-call (form)
   (if byte-compile-generate-call-tree
       (byte-compile-annotate-call-tree form))
+  (when (and for-effect (eq (car form) 'mapcar))
+    (byte-compile-set-symbol-position 'mapcar)
+    (byte-compile-warn
+     "`mapcar' called for effect; use `mapc' or `dolist' instead"))
   (byte-compile-push-constant (car form))
   (mapc 'byte-compile-form (cdr form)) ; wasteful, but faster.
   (byte-compile-out 'byte-call (length (cdr form))))