Enable giving hints to ImageMagick via :content-type

2013-08-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.el (image-content-type-suffixes): New variable.

2013-08-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* image.c (imagemagick_filename_hint): New function to possibly
	apply `image-content-type-suffixes'.
	(imagemagick_load_image): Use it.

diff --git a/doc/lispref/ChangeLog b/doc/lispref/ChangeLog
index 42b9600a0acae5c8864b24111e303e4031033ad4..0d7d13ea4e70b4865dbbf4099e25e1363d2331e0 100644 (file)
--- a/doc/lispref/ChangeLog
+++ b/doc/lispref/ChangeLog
@@ -1,3 +1,8 @@
+2013-08-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>
+
+       * display.texi (ImageMagick Images): Mention :content-type and
+       `image-content-type-suffixes'.
+
 2013-08-13  Xue Fuqiao  <xfq.free@gmail.com>
 
        * positions.texi (Word Motion): Remove redundant sentence.

diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi
index 6b8d24179e79f720f7679f28774e70828379cb71..f2fd51e6ae555e0817f782161f71e3c467f54040 100644 (file)
--- a/doc/lispref/display.texi
+++ b/doc/lispref/display.texi
@@ -4664,6 +4664,14 @@ and if @code{:height} is set it will have precedence over
 wish.  @code{:max-width} and @code{:max-height} will always preserve
 the aspect ratio.
 
+@item :content-type
+ImageMagick tries to auto-detect the image type, but it isn't always
+able to.  By using @code{:content-type}, we can give ImageMagick a
+hint to try to help it.  It's used in conjuction with the
+@code{image-content-type-suffixes} variable, which provides a mapping
+from content types to file name suffixes.  This is then given to
+ImageMagick as a file name hint.
+
 @item :rotation
 Specifies a rotation angle in degrees.
 

diff --git a/etc/NEWS b/etc/NEWS
index 715f7906073f454cd7a2fc413183d65a2c12e6ec..80310ea19a11d0722705085f0317ff331197ef67 100644 (file)
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -896,6 +896,10 @@ treated as images.
 *** ImageMagick images now support the :max-width and :max-height
 keywords.
 
+*** Some data types aren't auto-detected by ImageMagick.  Adding
+:content-type to `create-image' may help if the content type is in the
+new variable `image-content-type-suffixes'.
+
 ** Minibuffer
 
 *** In minibuffer filename prompts, `C-M-f' and `C-M-b' now move to the

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 11e5e91339866aba964f497e22a32aed1265dc3f..c6f11fec11adb3753cac2c681b9189d041245e7d 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2013-08-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>
+
+       * image.el (image-content-type-suffixes): New variable.
+
 2013-08-13  Fabián Ezequiel Gallina  <fgallina@gnu.org>
 
        * progmodes/python.el (python-imenu--build-tree)

diff --git a/lisp/image.el b/lisp/image.el
index 804dc3af5eaa824c7542537f72cb7598ddfcd9ac..de69490f5b609d529e9e9454a6208b8e1d79c34f 100644 (file)
--- a/lisp/image.el
+++ b/lisp/image.el
@@ -99,6 +99,14 @@ AUTODETECT can be
  - maybe  auto-detect only if the image type is available
            (see `image-type-available-p').")
 
+(defvar image-content-type-suffixes
+  '((image/x-icon "ico"))
+  "Alist of MIME Content-Type headers to file name suffixes.
+This is used as a hint by the ImageMagick library when detecting
+image types.  If `create-image' is called with a :content-type
+matching found in this alist, the ImageMagick library will be
+told that the data would have this suffix if saved to a file.")
+
 (defcustom image-load-path
   (list (file-name-as-directory (expand-file-name "images" data-directory))
         'data-directory 'load-path)

diff --git a/src/ChangeLog b/src/ChangeLog
index 1cb8002ccf7e4218f8fc8fdad6ad6f4c18222298..c60b2c19acf25a13bef8f846fa3c1e3b422f9578 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,9 @@
+2013-08-13  Lars Magne Ingebrigtsen  <larsi@gnus.org>
+
+       * image.c (imagemagick_filename_hint): New function to possibly
+       apply `image-content-type-suffixes'.
+       (imagemagick_load_image): Use it.
+
 2013-08-13  Eli Zaretskii  <eliz@gnu.org>
 
        * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil

diff --git a/src/image.c b/src/image.c
index ae38b4f764880fed5e5810a357e263959030ca89..35cbbb631aee7e28715ff010c97340e7dc016468 100644 (file)
--- a/src/image.c
+++ b/src/image.c
@@ -551,6 +551,7 @@ static Lisp_Object QCheuristic_mask;
 static Lisp_Object QCcolor_symbols;
 static Lisp_Object QCindex, QCmatrix, QCcolor_adjustment, QCmask, QCgeometry;
 static Lisp_Object QCcrop, QCrotation;
+static Lisp_Object QCcontent_type;
 
 /* Other symbols.  */
 
@@ -7740,6 +7741,7 @@ enum imagemagick_keyword_index
     IMAGEMAGICK_WIDTH,
     IMAGEMAGICK_MAX_HEIGHT,
     IMAGEMAGICK_MAX_WIDTH,
+    IMAGEMAGICK_CONTENT_TYPE,
     IMAGEMAGICK_ROTATION,
     IMAGEMAGICK_CROP,
     IMAGEMAGICK_LAST
@@ -7764,6 +7766,7 @@ static struct image_keyword imagemagick_format[IMAGEMAGICK_LAST] =
     {":width",         IMAGE_INTEGER_VALUE,                    0},
     {":max-height",    IMAGE_INTEGER_VALUE,                    0},
     {":max-width",     IMAGE_INTEGER_VALUE,                    0},
+    {":content-type",  IMAGE_SYMBOL_VALUE,                     0},
     {":rotation",      IMAGE_NUMBER_VALUE,                     0},
     {":crop",          IMAGE_DONT_CHECK_VALUE_TYPE,            0}
   };
@@ -7842,6 +7845,30 @@ imagemagick_error (MagickWand *wand)
   description = (char *) MagickRelinquishMemory (description);
 }
 
+/* Possibly give ImageMagick some extra help to determine the image
+   type by supplying a "dummy" filename based on the Content-Type. */
+
+static char*
+imagemagick_filename_hint (Lisp_Object spec)
+{
+  Lisp_Object content_type = image_spec_value (spec, QCcontent_type, NULL);
+  Lisp_Object symbol = intern ("image-content-type-suffixes");
+  Lisp_Object suffix;
+  char *name, *prefix = "/tmp/foo.";
+
+  if (NILP (Fboundp (symbol)))
+    return NULL;
+
+  suffix = Fcar (Fcdr (Fassq (content_type, Fsymbol_value (symbol))));
+  if (! STRINGP (suffix))
+    return NULL;
+
+  name = xmalloc (strlen (prefix) + SBYTES (suffix) + 1);
+  strcpy(name, prefix);
+  strcat(name, SDATA (suffix));
+  return name;
+}
+
 /* Helper function for imagemagick_load, which does the actual loading
    given contents and size, apart from frame and image structures,
    passed from imagemagick_load.  Uses librimagemagick to do most of
@@ -7875,6 +7902,7 @@ imagemagick_load_image (struct frame *f, struct image *img,
   int desired_width, desired_height;
   double rotation;
   int pixelwidth;
+  char *filename_hint = NULL;
 
   /* Handle image index for image types who can contain more than one image.
      Interface :index is same as for GIF.  First we "ping" the image to see how
@@ -7888,6 +7916,12 @@ imagemagick_load_image (struct frame *f, struct image *img,
   ping_wand = NewMagickWand ();
   /* MagickSetResolution (ping_wand, 2, 2);   (Bug#10112)  */
 
+  if (! filename)
+    filename_hint = imagemagick_filename_hint (img->spec);
+
+  if (filename_hint)
+    MagickSetFilename (ping_wand, filename_hint);
+
   status = filename
     ? MagickPingImage (ping_wand, filename)
     : MagickPingImageBlob (ping_wand, contents, size);
@@ -7920,6 +7954,9 @@ imagemagick_load_image (struct frame *f, struct image *img,
 
   image_wand = NewMagickWand ();
 
+  if (filename_hint)
+    MagickSetFilename (image_wand, filename_hint);
+
   if ((filename
        ? MagickReadImage (image_wand, filename)
        : MagickReadImageBlob (image_wand, contents, size))
@@ -8163,11 +8200,16 @@ imagemagick_load_image (struct frame *f, struct image *img,
   /* `MagickWandTerminus' terminates the imagemagick environment.  */
   MagickWandTerminus ();
 
+  if (filename_hint)
+    free (filename_hint);
+
   return 1;
 
  imagemagick_error:
   DestroyMagickWand (image_wand);
   if (bg_wand) DestroyPixelWand (bg_wand);
+  if (filename_hint)
+    free (filename_hint);
 
   MagickWandTerminus ();
   /* TODO more cleanup.  */
@@ -9105,6 +9147,7 @@ non-numeric, there is no explicit limit on the size of images.  */);
   DEFSYM (Qpostscript, "postscript");
   DEFSYM (QCmax_width, ":max-width");
   DEFSYM (QCmax_height, ":max-height");
+  DEFSYM (QCcontent_type, ":content-type");
 #ifdef HAVE_GHOSTSCRIPT
   ADD_IMAGE_TYPE (Qpostscript);
   DEFSYM (QCloader, ":loader");