+2006-01-18 Stefan Monnier <monnier@iro.umontreal.ca>
+
+ * url-news.el: Move defvars out of eval-when-compile.
+ (url-news-fetch-message-id, url-news-fetch-newsgroup):
+ Use with-current-buffer.
+
2006-01-10 Stefan Monnier <monnier@iro.umontreal.ca>
* url.el (url-retrieve-synchronously): Adjust the workaround so as not
;;; url-news.el --- News Uniform Resource Locator retrieval code
;; Copyright (C) 1996, 1997, 1998, 1999, 2004,
-;; 2005 Free Software Foundation, Inc.
+;; 2005, 2006 Free Software Foundation, Inc.
;; Keywords: comm, data, processes
(require 'nntp)
(autoload 'url-warn "url")
(autoload 'gnus-group-read-ephemeral-group "gnus-group")
-(eval-when-compile
- (require 'cl)
- (defvar nntp-open-tls-stream)
- (defvar nntp-open-ssl-stream))
+(eval-when-compile (require 'cl))
+(defvar nntp-open-tls-stream)
+(defvar nntp-open-ssl-stream)
(defgroup url-news nil
"News related options."
(if (cdr-safe (nntp-request-article message-id nil host buf))
;; Successfully retrieved the article
nil
- (save-excursion
- (set-buffer buf)
+ (with-current-buffer buf
(insert "Content-type: text/html\n\n"
"<html>\n"
" <head>\n"
;; This saves us from checking new news if Gnus is already running
;; FIXME - is it relatively safe to use gnus-alive-p here? FIXME
(if (or (not (get-buffer gnus-group-buffer))
- (save-excursion
- (set-buffer gnus-group-buffer)
+ (with-current-buffer gnus-group-buffer
(not (eq major-mode 'gnus-group-mode))))
(gnus))
(set-buffer gnus-group-buffer)
(port (url-port url))
(article-brackets nil)
(buf nil)
- (article (url-filename url)))
+ (article (url-unhex-string (url-filename url))))
(url-news-open-host host port (url-user url) (url-password url))
- (setq article (url-unhex-string article))
(cond
((string-match "@" article) ; Its a specific article
(setq buf (url-news-fetch-message-id host article)))
(provide 'url-news)
-;;; arch-tag: 8975be13-04e8-4d38-bfff-47918e3ad311
+;; arch-tag: 8975be13-04e8-4d38-bfff-47918e3ad311
;;; url-news.el ends here
projects / emacs.git / commitdiff