(font_unparse_xlfd): Don't ignore integer pixel size specs.

diff --git a/src/ChangeLog b/src/ChangeLog
index 8f89ffede5f4e6494a9dea5584b46229967b25e9..89d762264864927494724f4c19fcc07a1e3fae5d 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2008-02-18  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+       * font.c (font_unparse_xlfd): Don't ignore integer pixel size specs.
+
 2008-02-18  Jan Dj\e$(Q)Z\e(Brv  <jan.h.d@swipnet.se>
 
        * xfns.c (Fx_show_tip): Set string to " " if empty.

diff --git a/src/font.c b/src/font.c
index 70b239694c058a52254006c9fb7d846b94dfc9a0..b8da3de5ac76d6a8e721315fc6b81271c25f06b3 100644 (file)
--- a/src/font.c
+++ b/src/font.c
@@ -75,7 +75,7 @@ Lisp_Object Qiso8859_1, Qiso10646_1, Qunicode_bmp, Qunicode_sip;
 
 #define CHECK_VALIDATE_FONT_SPEC(x)                            \
   do {                                                         \
-    if (! FONT_SPEC_P (x)) x = wrong_type_argument (Qfont, x); \
+    if (! FONT_SPEC_P (x)) wrong_type_argument (Qfont, x);     \
     x = font_prop_validate (x);                                        \
   } while (0)
 
@@ -1161,18 +1161,21 @@ font_unparse_xlfd (font, pixel_size, name, nbytes)
   xassert (NUMBERP (val) || NILP (val));
   if (INTEGERP (val))
     {
-      f[XLFD_PIXEL_INDEX] = alloca (22);
-      i = XINT (val);
+      int i = XINT (val);
+      if (i <= 0)
+       i = pixel_size;
       if (i > 0)
-       len += sprintf (f[XLFD_PIXEL_INDEX], "%d-*", i) + 1;
-      else if (pixel_size > 0)
-       len += sprintf (f[XLFD_PIXEL_INDEX], "%d-*", pixel_size) + 1;
-      f[XLFD_PIXEL_INDEX] = "*-*", len += 4;
+       {
+         f[XLFD_PIXEL_INDEX] = alloca (22);
+         len += sprintf (f[XLFD_PIXEL_INDEX], "%d-*", i) + 1;
+       }
+      else
+       f[XLFD_PIXEL_INDEX] = "*-*", len += 4;
     }
   else if (FLOATP (val))
     {
+      int i = XFLOAT_DATA (val) * 10;
       f[XLFD_PIXEL_INDEX] = alloca (12);
-      i = XFLOAT_DATA (val) * 10;
       len += sprintf (f[XLFD_PIXEL_INDEX], "*-%d", i) + 1;
     }
   else