Revert "Remove the binding for xref-quit-and-goto-xref"

This reverts commit 522c34f0e80f60969861b0dc34bc7105249f9994.

Making changes to which there was an explicit disagreement
and a long discussion is unacceptable.  (Bug#44611)

diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi
index 32f5cb9a4396c18b05f17d922c184282b691c8cd..dfe4eb0ea302eb491b4e5e11a032b130da770354 100644 (file)
--- a/doc/emacs/maintaining.texi
+++ b/doc/emacs/maintaining.texi
@@ -2242,9 +2242,10 @@ display it in the other window (@code{xref-prev-group}).
 Display the reference on the current line in the other window
 (@code{xref-show-location-at-point}).
 
-@kindex C-u RET
-To bury the @file{*xref*} buffer before displaying the reference, call
-@code{xref-goto-xref} with a prefix argument: @kbd{C-u RET}.
+@item @key{TAB}
+@findex xref-quit-and-goto-xref
+Display the reference on the current line and bury the @file{*xref*}
+buffer (@code{xref-quit-and-goto-xref}).
 
 @item r @var{pattern} @key{RET} @var{replacement} @key{RET}
 Perform interactive query-replace on references that match

diff --git a/etc/NEWS b/etc/NEWS
index 34aeaf028b8b620c0a955614a535e8b76445073b..61904767b9474b56d61bf1659a9a2dc5835c40e1 100644 (file)
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1644,19 +1644,11 @@ in 'project-list-file'.
 
 ** xref
 
-+++
+---
 *** Prefix arg of 'xref-goto-xref' quits the "*xref*" buffer.
 So typing 'C-u RET' in the "*xref*" buffer quits its window
 before navigating to the selected location.
 
-+++
-*** The TAB binding in *xref* buffers has been removed. Use 'C-u RET' instead.
-To restore the old binding, say something like:
-
-    (require 'xref)
-    (define-key xref--xref-buffer-mode-map
-                (kbd "TAB") #'xref-quit-and-goto-xref)
-
 *** New user options 'xref-search-program' and 'xref-search-program-alist'.
 So far 'grep' and 'ripgrep' are supported.  'ripgrep' seems to offer better
 performance in certain cases, in particular for case-insensitive

diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 1e52318ba7b79f0e6e83b8429a5b33926390607f..63d25de50a7ed19502b7267dfed9c579c39866ce 100644 (file)
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -817,6 +817,7 @@ ITEMS is an xref item which "
     (define-key map (kbd "P") #'xref-prev-group)
     (define-key map (kbd "r") #'xref-query-replace-in-results)
     (define-key map (kbd "RET") #'xref-goto-xref)
+    (define-key map (kbd "TAB")  #'xref-quit-and-goto-xref)
     (define-key map (kbd "C-o") #'xref-show-location-at-point)
     ;; suggested by Johan Claesson "to further reduce finger movement":
     (define-key map (kbd ".") #'xref-next-line)