More undeclared function fixes and add -Wimplicit-function-declaration.

If a function returns Lisp_Object it must be declared, otherwise on a 64-bit
system, it will return just 32 bits (int).

* configure.in: Use -Wimplicit-function-declaration if compiler supports it.

* src/keyboard.h (poll_for_input_1): Unconditionally declare.

* src/xterm.h (x_get_focus_frame): Declare.

diff --git a/ChangeLog b/ChangeLog
index b03f6eda6e404c1cfc707bc8b3dcec8e4006c3b2..fbee7fb956261b650385ad6350bfd93bd3f9db75 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,7 @@
 2010-08-06  Jan Djärv  <jan.h.d@swipnet.se>
 
        * configure.in: Check for util.h.
+       Use -Wimplicit-function-declaration if compiler supports it.
 
 2010-08-05  Eli Zaretskii  <eliz@gnu.org>
 

diff --git a/configure b/configure
index 0ee4645cf5a1f555e206e1d95c23f51411e18dd4..53c2407f3a9f76bf23ec14ebe2343901880a6482 100755 (executable)
--- a/configure
+++ b/configure
@@ -4865,6 +4865,38 @@ CFLAGS="$SAVE_CFLAGS"
 unset has_option
 unset SAVE_CFLAGS
 
+### Use -Wimplicit-function-declaration if the compiler supports it
+{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether gcc understands -Wimplicit-function-declaration" >&5
+$as_echo_n "checking whether gcc understands -Wimplicit-function-declaration... " >&6; }
+SAVE_CFLAGS="$CFLAGS"
+CFLAGS="$CFLAGS -Wimplicit-function-declaration"
+cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h.  */
+
+int
+main ()
+{
+
+  ;
+  return 0;
+}
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+  has_option=yes
+else
+  has_option=no
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+if test $has_option = yes; then
+   C_WARNINGS_SWITCH="-Wimplicit-function-declaration $C_WARNINGS_SWITCH"
+fi
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $has_option" >&5
+$as_echo "$has_option" >&6; }
+CFLAGS="$SAVE_CFLAGS"
+unset has_option
+unset SAVE_CFLAGS
+
+
 
 
 #### Some other nice autoconf tests.

diff --git a/configure.in b/configure.in
index 92d2e9d00a277bf7dec37678de719135ea9b1ed1..fcd2faa76708c8cef61b03a7f34ae0f2461182cf 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -770,6 +770,20 @@ AC_MSG_RESULT($has_option)
 CFLAGS="$SAVE_CFLAGS"
 unset has_option
 unset SAVE_CFLAGS
+
+### Use -Wimplicit-function-declaration if the compiler supports it
+AC_MSG_CHECKING([whether gcc understands -Wimplicit-function-declaration])
+SAVE_CFLAGS="$CFLAGS"
+CFLAGS="$CFLAGS -Wimplicit-function-declaration"
+AC_TRY_COMPILE([], [], has_option=yes, has_option=no,)
+if test $has_option = yes; then
+   C_WARNINGS_SWITCH="-Wimplicit-function-declaration $C_WARNINGS_SWITCH"
+fi
+AC_MSG_RESULT($has_option)
+CFLAGS="$SAVE_CFLAGS"
+unset has_option
+unset SAVE_CFLAGS
+
 AC_SUBST(C_WARNINGS_SWITCH)
 
 

diff --git a/src/ChangeLog b/src/ChangeLog
index bef939adb4fdf97d5c01cf6249a6e8ff4ebee33b..835fe921019abf365d10d9d4153976fb60b21a9a 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,9 @@
 2010-08-06  Jan Djärv  <jan.h.d@swipnet.se>
 
+       * xterm.h (x_get_focus_frame): Declare.
+
+       * keyboard.h (poll_for_input_1): Unconditionally declare.
+
        * nsterm.h (x_set_menu_bar_lines): Declare.
 
        * window.c: Don't include menu.h, it depends on lots of other .h-files.

diff --git a/src/keyboard.h b/src/keyboard.h
index 48d7f1468d91d1aefc52c3142fe1b90088d68f59..9ef558fc4e1077d3cf6fbfc96c44762c3ecdce3b 100644 (file)
--- a/src/keyboard.h
+++ b/src/keyboard.h
@@ -515,9 +515,7 @@ extern void kbd_buffer_store_event (struct input_event *);
 extern void kbd_buffer_store_event_hold (struct input_event *,
                                          struct input_event *);
 extern void kbd_buffer_unget_event (struct input_event *);
-#ifdef POLL_FOR_INPUT
 extern void poll_for_input_1 (void);
-#endif
 extern void show_help_echo (Lisp_Object, Lisp_Object, Lisp_Object,
                             Lisp_Object, int);
 extern void gen_help_event (Lisp_Object, Lisp_Object, Lisp_Object,

diff --git a/src/xterm.h b/src/xterm.h
index 7a35466cb79f5966b33917d62b4b845a3ba83b22..69c8ec22a73283febf88ad5a4213953e7d2efac4 100644 (file)
--- a/src/xterm.h
+++ b/src/xterm.h
@@ -1058,6 +1058,7 @@ extern Lisp_Object x_property_data_to_lisp (struct frame *,
 /* Defined in xfns.c */
 
 extern struct x_display_info * check_x_display_info (Lisp_Object frame);
+extern Lisp_Object x_get_focus_frame (struct frame *);
 
 #ifdef USE_GTK
 extern int xg_set_icon (struct frame *, Lisp_Object);