Give a name FLOAT_TO_STRING_BUFSIZE to the constant 350.

* lisp.h (FLOAT_TO_STRING_BUFSIZE): New macro.
* data.c (Fnumber_to_string): Use it.
* print.c (float_to_string, print_object): Likewise.

diff --git a/src/ChangeLog b/src/ChangeLog
index 7374c4d878d103a35c886e7e04e5aab4b80ad90e..353f9c2d64a9e664e16fec1e508f165c66901394 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,10 @@
 2011-01-09  Paul Eggert  <eggert@cs.ucla.edu>
 
+       Give a name FLOAT_TO_STRING_BUFSIZE to the constant 350.
+       * lisp.h (FLOAT_TO_STRING_BUFSIZE): New macro.
+       * data.c (Fnumber_to_string): Use it.
+       * print.c (float_to_string, print_object): Likewise.
+
        Include <unistd.h> unilaterally.
        * alloc.c, atimer.c, buffer.c, callproc.c, dired.c, dispnew.c, doc.c:
        * doprnt.c, editfns.c, emacs.c, fileio.c, filelock.c, fns.c:

diff --git a/src/data.c b/src/data.c
index 8816d7201f3f3d39c3d7ff431beb029781899879..31cf0fcde517df8b61f40ae533aedcd8d16fc911 100644 (file)
--- a/src/data.c
+++ b/src/data.c
@@ -2375,7 +2375,7 @@ NUMBER may be an integer or a floating point number.  */)
 
   if (FLOATP (number))
     {
-      char pigbuf[350];        /* see comments in float_to_string */
+      char pigbuf[FLOAT_TO_STRING_BUFSIZE];
 
       float_to_string (pigbuf, XFLOAT_DATA (number));
       return build_string (pigbuf);

diff --git a/src/lisp.h b/src/lisp.h
index eadbbacbff4e83b918603792f3fa8fd5e4e82a44..1f507123d836b340c3ef45dd16b3eb7d42f46df5 100644 (file)
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -2781,6 +2781,7 @@ extern void print_error_message (Lisp_Object, Lisp_Object, const char *,
                                 Lisp_Object);
 extern Lisp_Object internal_with_output_to_temp_buffer
         (const char *, Lisp_Object (*) (Lisp_Object), Lisp_Object);
+#define FLOAT_TO_STRING_BUFSIZE 350
 extern void float_to_string (unsigned char *, double);
 extern void syms_of_print (void);
 

diff --git a/src/print.c b/src/print.c
index 993b17b668d556a5fd9fcdc747fca484e5cac636..961400f472683b498cea4c52e4f544ea9495ec9a 100644 (file)
--- a/src/print.c
+++ b/src/print.c
@@ -1054,6 +1054,7 @@ print_error_message (Lisp_Object data, Lisp_Object stream, const char *context,
  * case of -1e307 in 20d float_output_format. What is one to do (short of
  * re-writing _doprnt to be more sane)?
  *                     -wsr
+ * Given the above, the buffer must be least FLOAT_TO_STRING_BUFSIZE bytes.
  */
 
 void
@@ -1100,9 +1101,8 @@ float_to_string (unsigned char *buf, double data)
   lose:
     {
       /* Generate the fewest number of digits that represent the
-        floating point value without losing information.
-         The 350 is by convention, e.g., this file's pigbuf.  */
-      dtoastr (buf, 350, 0, 0, data);
+        floating point value without losing information.  */
+      dtoastr (buf, FLOAT_TO_STRING_BUFSIZE, 0, 0, data);
     }
   else                 /* oink oink */
     {
@@ -1493,7 +1493,7 @@ print_object (Lisp_Object obj, register Lisp_Object printcharfun, int escapeflag
 
     case Lisp_Float:
       {
-       char pigbuf[350];       /* see comments in float_to_string */
+       char pigbuf[FLOAT_TO_STRING_BUFSIZE];
 
        float_to_string (pigbuf, XFLOAT_DATA (obj));
        strout (pigbuf, -1, -1, printcharfun, 0);