Fix a mis-binding and a bad defun name in a test (Bug#28319)

test/lib-src/emacs-client-tests.el (call-emacsclient): Rename
emacsclient-test-call-emacsclient.
(emacsclient-test-alternate-editor-allows-arguments)
(emacsclient-test-alternate-editor-allows-quotes): Fix let-binding of
process-environment.

Thanks to Glenn Morris for noticing these errors.

diff --git a/test/lib-src/emacsclient-tests.el b/test/lib-src/emacsclient-tests.el
index e454e2825e6304ad4bb6af0a9b35af7300f3be32..91f1f1002d568669e98c2fb68a92c4c0a60b0a7c 100644 (file)
--- a/test/lib-src/emacsclient-tests.el
+++ b/test/lib-src/emacsclient-tests.el
@@ -31,26 +31,26 @@
                                    "lib-src"))
   "Path to emacsclient binary in build tree.")
 
-(defun call-emacsclient ()
+(defun emacsclient-test-call-emacsclient ()
   "Run emacsclient."
   (call-process emacsclient-test-emacs nil nil nil
                 "--server-file" (expand-file-name "non-existent-file" invocation-directory)
                 "foo"))
 
 (ert-deftest emacsclient-test-alternate-editor-allows-arguments ()
-  (let (process-environment process-environment)
+  (let ((process-environment process-environment))
     (setenv "ALTERNATE_EDITOR" (concat
                                 (expand-file-name invocation-name invocation-directory)
                                 " --batch"))
-    (should (= 0 (call-emacsclient)))))
+    (should (= 0 (emacsclient-test-call-emacsclient)))))
 
 (ert-deftest emacsclient-test-alternate-editor-allows-quotes ()
-  (let (process-environment process-environment)
+  (let ((process-environment process-environment))
     (setenv "ALTERNATE_EDITOR" (concat
                                 "\""
                                 (expand-file-name invocation-name invocation-directory)
                                 "\"" " --batch"))
-    (should (= 0 (call-emacsclient)))))
+    (should (= 0 (emacsclient-test-call-emacsclient)))))
 
 (provide 'emacsclient-tests)
 ;;; emacsclient-tests.el ends here