* ccl.c: Integer and memory overflow fixes.

(Fccl_execute_on_string): Check for memory overflow.
Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
Redo buffer-overflow calculations to avoid integer overflow.

diff --git a/src/ChangeLog b/src/ChangeLog
index 9b9a9686259b0cd052dc161b26fb7f65df8e4832..b35f5607619c9a41c4e8fef36d3ae19d58402dfd 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,10 @@
 2011-07-28  Paul Eggert  <eggert@cs.ucla.edu>
 
+       * ccl.c: Integer and memory overflow fixes.
+       (Fccl_execute_on_string): Check for memory overflow.
+       Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
+       Redo buffer-overflow calculations to avoid integer overflow.
+
        * callproc.c (child_setup): Don't assume strlen fits in int.
 
        * buffer.c: Memory overflow fixes.

diff --git a/src/ccl.c b/src/ccl.c
index 087c0feb4abbdf852caddc394179ac448a140ad6..0a9b3d907084329d4788419d44a26a03d4e00995 100644 (file)
--- a/src/ccl.c
+++ b/src/ccl.c
@@ -2061,12 +2061,12 @@ usage: (ccl-execute-on-string CCL-PROGRAM STATUS STRING &optional CONTINUE UNIBY
   Lisp_Object val;
   struct ccl_program ccl;
   int i;
-  EMACS_INT outbufsize;
+  ptrdiff_t outbufsize;
   unsigned char *outbuf, *outp;
-  EMACS_INT str_chars, str_bytes;
+  ptrdiff_t str_chars, str_bytes;
 #define CCL_EXECUTE_BUF_SIZE 1024
   int source[CCL_EXECUTE_BUF_SIZE], destination[CCL_EXECUTE_BUF_SIZE];
-  EMACS_INT consumed_chars, consumed_bytes, produced_chars;
+  ptrdiff_t consumed_chars, consumed_bytes, produced_chars;
 
   if (setup_ccl_program (&ccl, ccl_prog) < 0)
     error ("Invalid CCL program");
@@ -2093,6 +2093,10 @@ usage: (ccl-execute-on-string CCL-PROGRAM STATUS STRING &optional CONTINUE UNIBY
        ccl.ic = i;
     }
 
+  if (((min (PTRDIFF_MAX, SIZE_MAX) - 256)
+       / (ccl.buf_magnification ? ccl.buf_magnification : 1))
+      < str_bytes)
+    memory_full (SIZE_MAX);
   outbufsize = (ccl.buf_magnification
                ? str_bytes * ccl.buf_magnification + 256
                : str_bytes + 256);
@@ -2127,11 +2131,19 @@ usage: (ccl-execute-on-string CCL-PROGRAM STATUS STRING &optional CONTINUE UNIBY
          produced_chars += ccl.produced;
          if (NILP (unibyte_p))
            {
-             if (outp - outbuf + MAX_MULTIBYTE_LENGTH * ccl.produced
-                 > outbufsize)
+             ptrdiff_t offset = outp - outbuf;
+             if ((outbufsize - offset) / MAX_MULTIBYTE_LENGTH < ccl.produced)
                {
-                 EMACS_INT offset = outp - outbuf;
-                 outbufsize += MAX_MULTIBYTE_LENGTH * ccl.produced;
+                 ptrdiff_t produced;
+                 if (((min (PTRDIFF_MAX, SIZE_MAX) - outbufsize)
+                      / MAX_MULTIBYTE_LENGTH)
+                     < ccl.produced)
+                   {
+                     xfree (outbuf);
+                     memory_full (SIZE_MAX);
+                   }
+                 produced = ccl.produced;
+                 outbufsize += MAX_MULTIBYTE_LENGTH * produced;
                  outbuf = (unsigned char *) xrealloc (outbuf, outbufsize);
                  outp = outbuf + offset;
                }
@@ -2140,9 +2152,14 @@ usage: (ccl-execute-on-string CCL-PROGRAM STATUS STRING &optional CONTINUE UNIBY
            }
          else
            {
-             if (outp - outbuf + ccl.produced > outbufsize)
+             ptrdiff_t offset = outp - outbuf;
+             if (outbufsize - offset < ccl.produced)
                {
-                 EMACS_INT offset = outp - outbuf;
+                 if (min (PTRDIFF_MAX, SIZE_MAX) - outbufsize < ccl.produced)
+                   {
+                     xfree (outbuf);
+                     memory_full (SIZE_MAX);
+                   }
                  outbufsize += ccl.produced;
                  outbuf = (unsigned char *) xrealloc (outbuf, outbufsize);
                  outp = outbuf + offset;