Signal an error for duplicated ERT tests (bug#51941)

Make `ert-deftest` fail with an error (in batch mode only) if an
existing test is redefined, because that is an easy mistake to make
and which leads to a test being discarded silently.

lisp/emacs-lisp/ert.el (ert-set-test, ert-deftest): Add check.
etc/NEWS: Announce.

diff --git a/etc/NEWS b/etc/NEWS
index 80be6c0e49854bd9f01a557fe60fc7199e920af5..cee2844be3a5bf101f93669520ad425518ce6923 100644 (file)
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -64,6 +64,13 @@ the 'COLORTERM' environment variable is set to the value "truecolor".
 These variables will override 'print-length' and 'print-level' when
 printing Lisp values in ERT batch test results.
 
+---
+** Redefining an ERT test in batch mode now signals an error
+Executing 'ert-deftest' with the same name as an existing test causes
+the previous definition to be discarded, which was probably not
+intended when this occurs in batch mode.  To remedy the error, rename
+tests so that they all have unique names.
+
 ** Emacs now supports Unicode Standard version 14.0.
 
 ** Emoji

diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el
index 36b4408dc8e5f7f1c5543c75a905841ff84a9f5e..dc9cbc4745820d181b9abc6b2291902bfb3ce8c1 100644 (file)
--- a/lisp/emacs-lisp/ert.el
+++ b/lisp/emacs-lisp/ert.el
@@ -151,6 +151,10 @@ in batch mode.")
     ;; Note that nil is still a valid value for the `name' slot in
     ;; ert-test objects.  It designates an anonymous test.
     (error "Attempt to define a test named nil"))
+  (when (and noninteractive (get symbol 'ert--test))
+    ;; Make sure duplicated tests are discovered since the older test would
+    ;; be ignored silently otherwise.
+    (error "Test `%s' redefined" symbol))
   (define-symbol-prop symbol 'ert--test definition)
   definition)
 
@@ -206,6 +210,9 @@ Macros in BODY are expanded when the test is defined, not when it
 is run.  If a macro (possibly with side effects) is to be tested,
 it has to be wrapped in `(eval (quote ...))'.
 
+If NAME is already defined as a test and Emacs is running
+in batch mode, an error is signalled.
+
 \(fn NAME () [DOCSTRING] [:expected-result RESULT-TYPE] \
 [:tags \\='(TAG...)] BODY...)"
   (declare (debug (&define [&name "test@" symbolp]