]> git.eshelyaron.com Git - emacs.git/commitdiff
; * lisp/vc/log-view.el (log-view-modify-change-comment): Add FIXME.
authorSean Whitton <spwhitton@spwhitton.name>
Sun, 20 Oct 2024 01:20:07 +0000 (09:20 +0800)
committerEshel Yaron <me@eshelyaron.com>
Tue, 22 Oct 2024 19:00:13 +0000 (21:00 +0200)
(cherry picked from commit de0800c511740de7ad4dcb7dda0a0083a094d749)

lisp/vc/log-view.el

index 647a7dc569f67c9cb51eae6b3824067b7cc553db..360f522272b5abaf9822a5547caa40f66b08db6d 100644 (file)
@@ -550,6 +550,12 @@ If called interactively, visit the version at point."
          (rev (log-view-current-tag))
          ;; `log-view-extract-comment' is the legacy code for this; the
          ;; `get-change-comment' backend action is the new way to do it.
+         ;;
+         ;; FIXME: Eventually the older backends should have
+         ;; implementations of `get-change-comment' because that ought
+         ;; to be more robust than the approach taken by
+         ;; `log-view-extract-comment'.  Then we can delete the latter.
+         ;; See discussion in bug#64055.  --spwhitton
          (comment (condition-case _
                       (vc-call-backend log-view-vc-backend
                                        'get-change-comment files rev)