Port --enable-gcc-warnings to GCC 8

Backport from master.
* lib-src/emacsclient.c (fail):
Do not dereference a null pointer.
* src/frame.c (delete_frame):
Add a decl with UNINIT to work around GCC bug 85563.
* src/menu.h (finish_menu_items):
Do not use attribute const.
* src/regex.c (analyze_first): Use FALLTHROUGH, not a comment.

diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c
index 574bec850fa692bcc7080495a8d799eb5c9add50..b139b2fe3f60349b812a661d2113c8c3abc9cc8f 100644 (file)
--- a/lib-src/emacsclient.c
+++ b/lib-src/emacsclient.c
@@ -700,7 +700,7 @@ fail (void)
     {
       size_t extra_args_size = (main_argc - optind + 1) * sizeof (char *);
       size_t new_argv_size = extra_args_size;
-      char **new_argv = NULL;
+      char **new_argv = xmalloc (new_argv_size);
       char *s = xstrdup (alternate_editor);
       unsigned toks = 0;
 

diff --git a/src/frame.c b/src/frame.c
index cee775c6fa9f02f63def81d586c8198dc1cda2a9..0a6ca26f5d7467004c99c4f3c97758a99a05d99e 100644 (file)
--- a/src/frame.c
+++ b/src/frame.c
@@ -1933,6 +1933,7 @@ delete_frame (Lisp_Object frame, Lisp_Object force)
   if (f == sf)
     {
       Lisp_Object tail;
+      Lisp_Object frame1 UNINIT;  /* This line works around GCC bug 85563.  */
       eassume (CONSP (Vframe_list));
 
       /* Look for another visible frame on the same terminal.

diff --git a/src/menu.h b/src/menu.h
index 4c4ac83424f402c8e751f397d28c9cb1ba7ac8e4..1aa53f74544cbcc2cf83596ed85cf3cd5f4f8212 100644 (file)
--- a/src/menu.h
+++ b/src/menu.h
@@ -30,7 +30,7 @@ enum {
 };
 
 extern void init_menu_items (void);
-extern void finish_menu_items (void) ATTRIBUTE_CONST;
+extern void finish_menu_items (void);
 extern void discard_menu_items (void);
 extern void save_menu_items (void);
 extern bool parse_single_submenu (Lisp_Object, Lisp_Object, Lisp_Object);

diff --git a/src/regex.c b/src/regex.c
index e8b99f6f02362f4f8df919707d570bbb0f395f71..4f9df68a9feb7cfb7d4e69ae67abe9b00399685d 100644 (file)
--- a/src/regex.c
+++ b/src/regex.c
@@ -4038,8 +4038,7 @@ analyze_first (const_re_char *p, const_re_char *pend, char *fastmap,
            };
          /* Keep `p1' to allow the `on_failure_jump' we are jumping to
             to jump back to "just after here".  */
-         /* Fallthrough */
-
+         FALLTHROUGH;
        case on_failure_jump:
        case on_failure_keep_string_jump:
        case on_failure_jump_nastyloop: