]> git.eshelyaron.com Git - emacs.git/commitdiff
Fix long credentials when using auth in url.el
authorLars Ingebrigtsen <larsi@gnus.org>
Fri, 12 Jul 2019 23:27:32 +0000 (01:27 +0200)
committerLars Ingebrigtsen <larsi@gnus.org>
Fri, 12 Jul 2019 23:31:24 +0000 (01:31 +0200)
* lisp/url/url-auth.el (url-basic-auth): When base64-ing
credentials, don't let bsae64-encode-string split the result into
several lines, because servers do not understand that (bug#36619).

lisp/url/url-auth.el

index beed7c6cb62c0231dbffccb18be9934e7a25060d..b78544e3f37cfb9d336889c95d76f8848b0da59c 100644 (file)
@@ -82,7 +82,7 @@ instead of the filename inheritance method."
     (cond
      ((and user pass)
       ;; Explicit http://user:pass@foo/ URL.  Just return the credentials.
-      (setq retval (base64-encode-string (format "%s:%s" user pass))))
+      (setq retval (base64-encode-string (format "%s:%s" user pass) t)))
      ((and prompt (not byserv))
       (setq user (or
                  (url-do-auth-source-search server type :user)
@@ -97,7 +97,8 @@ instead of the filename inheritance method."
                             (setq retval
                                   (base64-encode-string
                                    (format "%s:%s" user
-                                           (encode-coding-string pass 'utf-8))))))
+                                           (encode-coding-string pass 'utf-8))
+                                    t))))
                 (symbol-value url-basic-auth-storage))))
      (byserv
       (setq retval (cdr-safe (assoc file byserv)))
@@ -120,7 +121,7 @@ instead of the filename inheritance method."
                  pass (or
                        (url-do-auth-source-search server type :secret)
                        (read-passwd "Password: "))
-                 retval (base64-encode-string (format "%s:%s" user pass))
+                 retval (base64-encode-string (format "%s:%s" user pass) t)
                  byserv (assoc server (symbol-value url-basic-auth-storage)))
            (setcdr byserv
                    (cons (cons file retval) (cdr byserv))))))