* net/shr.el (shr--extract-best-source): Ignore non-text children.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 157b2b45f9833415db28e25793148717289bd30f..1f0d7520b60aea6ca966bb50a1230144d33eaa3b 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2014-12-04  Lars Magne Ingebrigtsen  <larsi@gnus.org>
+
+       * net/shr.el (shr--extract-best-source): Ignore non-text children.
+
 2014-12-04  Eli Zaretskii  <eliz@gnu.org>
 
        Implement copying of a buffer portion while preserving visual order.

diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index 3ad8bd177777b8758b4ff3cc0a94096f818da5de..a2a122cf5d8eee1104940a5f79067a5eb56d433f 100644 (file)
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1184,7 +1184,7 @@ The preference is a float determined from `shr-prefer-media-type'."
   "Extract the best `:src' property from <source> blocks in DOM."
   (setq pref (or pref -1.0))
   (let (new-pref)
-    (dolist (elem (dom-children dom))
+    (dolist (elem (dom-non-text-children dom))
       (when (and (eq (dom-tag elem) 'source)
                 (< pref
                    (setq new-pref
@@ -1193,7 +1193,7 @@ The preference is a float determined from `shr-prefer-media-type'."
              url (dom-attr elem 'src))
         ;; libxml's html parser isn't HTML5 compliant and non terminated
         ;; source tags might end up as children.  So recursion it is...
-        (dolist (child (dom-children elem))
+        (dolist (child (dom-non-text-children elem))
           (when (eq (dom-tag child) 'source)
             (let ((ret (shr--extract-best-source (list child) url pref)))
               (when (< pref (cdr ret))