]> git.eshelyaron.com Git - emacs.git/commitdiff
Another fix for :extend when :inherit is used
authorEli Zaretskii <eliz@gnu.org>
Thu, 5 Dec 2019 17:58:02 +0000 (19:58 +0200)
committerEli Zaretskii <eliz@gnu.org>
Thu, 5 Dec 2019 17:58:02 +0000 (19:58 +0200)
* src/xfaces.c (face_inherited_attr): Support also values of
:inherit which are lists.  (Bug#37774)

src/xfaces.c

index 440cf4f1917622353a8a1e3d549082b7be3af5e5..6db4dcd226fcc2f7f2766d9d2507a0478ba494f5 100644 (file)
@@ -2163,11 +2163,31 @@ face_inherited_attr (struct window *w, struct frame *f,
         && !UNSPECIFIEDP (inherited_attrs[LFACE_INHERIT_INDEX]))
     {
       Lisp_Object parent_face = inherited_attrs[LFACE_INHERIT_INDEX];
-      bool ok = get_lface_attributes (w, f, parent_face, inherited_attrs,
-                                     false, named_merge_points);
-      if (!ok)
-       break;
-      attr_val = inherited_attrs[attr_idx];
+      bool ok;
+
+      if (CONSP (parent_face))
+       {
+         Lisp_Object tail;
+         for (tail = parent_face; !NILP (tail); tail = XCDR (tail))
+           {
+             ok = get_lface_attributes (w, f, XCAR (tail), inherited_attrs,
+                                        false, named_merge_points);
+             if (!ok)
+               break;
+             attr_val = face_inherited_attr (w, f, inherited_attrs, attr_idx,
+                                             named_merge_points);
+             if (!UNSPECIFIEDP (attr_val))
+               break;
+           }
+       }
+      else
+       {
+         ok = get_lface_attributes (w, f, parent_face, inherited_attrs,
+                                    false, named_merge_points);
+         if (!ok)
+           break;
+         attr_val = inherited_attrs[attr_idx];
+       }
     }
   return attr_val;
 }