Fix some issues with setting the frame height.

* frame.c (x_set_frame_parameters): Revert part of 2014-07-24
change that added the top margin height to the requested height
and revert (undocumented) part of 2014-07-28 change that changed
the logic of whether a size change occurred.

diff --git a/src/ChangeLog b/src/ChangeLog
index 0c79309609f6f7099f7067759f262087db43dacc..6f864d2333241d4ff9bc16e8631b6a8028d28844 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,10 @@
+2014-07-28  Martin Rudalics  <rudalics@gmx.at>
+
+       * frame.c (x_set_frame_parameters): Revert part of 2014-07-24
+       change that added the top margin height to the requested height
+       and revert (undocumented) part of 2014-07-28 change that changed
+       the logic of whether a size change occurred.
+
 2014-07-28  Eli Zaretskii  <eliz@gnu.org>
 
        * .gdbinit (xwindow): The members total_cols, total_lines,

diff --git a/src/frame.c b/src/frame.c
index cc0d77e54c865ce5b64d62462f9f929853d900f5..a911e71e822f4e6087723eb40f9446c6ebc6b852 100644 (file)
--- a/src/frame.c
+++ b/src/frame.c
@@ -3116,9 +3116,7 @@ x_set_frame_parameters (struct frame *f, Lisp_Object alist)
       else if (EQ (prop, Qheight) && RANGED_INTEGERP (0, val, INT_MAX))
         {
          height_change = 1;
-         /* Add menu and tool bar lines to correctly resize F pixelwise.  */
-          height
-           = (XFASTINT (val) + FRAME_TOP_MARGIN (f)) * FRAME_LINE_HEIGHT (f);
+          height = XFASTINT (val) * FRAME_LINE_HEIGHT (f);
         }
       else if (EQ (prop, Qtop))
        top = val;
@@ -3200,9 +3198,10 @@ x_set_frame_parameters (struct frame *f, Lisp_Object alist)
 
     XSETFRAME (frame, f);
 
-    if (((width_change && width != FRAME_TEXT_WIDTH (f))
-        || (height_change && height != FRAME_TEXT_HEIGHT (f)))
-        && (f->new_height || f->new_width))
+    if ((width_change || height_change)
+        && (width != FRAME_TEXT_WIDTH (f)
+            || height != FRAME_TEXT_HEIGHT (f)
+            || f->new_height || f->new_width))
       {
        /* If necessary provide default values for HEIGHT and WIDTH.  Do
           that here since otherwise a size change implied by an