(artist-replace-chars, artist-replace-char):

Check that emacs-major-version is `=' to 20, not `>='.
(artist-replace-chars): Use `make-string' instead of a loop.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 5b2fb3a1bb87b1ac14fd4d733ec5d0f788ff4d4d..b537260d74fd949677001271e205ee876d94db65 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,9 @@
+2000-12-18  Miles Bader  <miles@gnu.org>
+
+       * textmodes/artist.el (artist-replace-chars, artist-replace-char): 
+       Check that emacs-major-version is `=' to 20, not `>='.
+       (artist-replace-chars): Use `make-string' instead of a loop.
+
 2000-12-16  Eli Zaretskii  <eliz@is.elta.co.il>
 
        * textmodes/ispell.el (check-ispell-version): If

diff --git a/lisp/textmodes/artist.el b/lisp/textmodes/artist.el
index c6da8051f245f0ec3f1457ac3e7b3a40609bcc61..918cdffadf854f9fd99d8d4e8252d84df275dcbf 100644 (file)
--- a/lisp/textmodes/artist.el
+++ b/lisp/textmodes/artist.el
@@ -1899,7 +1899,7 @@ Also updates the variables `artist-draw-min-y' and `artist-draw-max-y'."
 (defun artist-replace-char (new-char)
   "Replace the character at point with NEW-CHAR."
   ;; Check that the variable exists first. The doc says it was added in 19.23.
-  (if (and (and (boundp 'emacs-major-version) (>= emacs-major-version 20))
+  (if (and (and (boundp 'emacs-major-version) (= emacs-major-version 20))
           (and (boundp 'emacs-minor-version) (<= emacs-minor-version 3)))
       ;; This is a bug workaround for Emacs 20, versions up to 20.3:
       ;; The self-insert-command doesn't care about the overwrite-mode,
@@ -1920,17 +1920,14 @@ Also updates the variables `artist-draw-min-y' and `artist-draw-max-y'."
 (defun artist-replace-chars (new-char count)
   "Replace characters at point with NEW-CHAR.  COUNT chars are replaced."
   ;; Check that the variable exists first. The doc says it was added in 19.23.
-  (if (and (and (boundp 'emacs-major-version) (>= emacs-major-version 20))
+  (if (and (and (boundp 'emacs-major-version) (= emacs-major-version 20))
           (and (boundp 'emacs-minor-version) (<= emacs-minor-version 3)))
       ;; This is a bug workaround for Emacs 20, versions up to 20.3:
       ;; The self-insert-command doesn't care about the overwrite-mode,
       ;; so the insertion is done in the same way as in picture mode.
       ;; This seems to be a little bit slower.
       (let* ((replaced-c (aref artist-replacement-table new-char))
-            (replaced-s (let ((tmp-s "") (i count))
-                          (while (> i 0)
-                            (setq i (1- i))
-                            (setq tmp-s (concat tmp-s replaced-c))))))
+            (replaced-s (make-string count replaced-c)))
        (artist-move-to-xy (+ (artist-current-column) count)
                           (artist-current-line))
        (delete-char (- count))