Fix <button>...</button> submit button rendering in eww

* lisp/net/eww.el (eww-form-submit): Use the contents of the
<button>...</button> for the string if there is no value
(bug#39326).

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 811d7c692091b2f849c2dcff979b480fd4b591f6..c83884fd2593f4369c491c9b60d2393a125f5fe7 100644 (file)
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1107,11 +1107,13 @@ just re-display the HTML already fetched."
 (defun eww-form-submit (dom)
   (let ((start (point))
        (value (dom-attr dom 'value)))
-    (setq value
-         (if (zerop (length value))
-             "Submit"
-           value))
-    (insert value)
+    (if (null value)
+        (shr-generic dom)
+      (insert value))
+    ;; If the contents of the <button>...</button> turns out to be
+    ;; empty, or the value was blank, default to this:
+    (when (= (point) start)
+      (insert "Submit"))
     (add-face-text-property start (point) 'eww-form-submit)
     (put-text-property start (point) 'eww-form
                       (list :eww-form eww-form