* src/eval.c (Fprogn): Do not check that BODY is a proper list.

This undoes the previous change.  The check slows down the
interpreter, and is not needed to prevent a crash.  See
<http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
* doc/lispref/eval.texi (Special Forms): Mention 'lambda'.  Also, say that
non-well-formed expressions result in unspecified behavior, though
Emacs will not crash.

diff --git a/doc/lispref/ChangeLog b/doc/lispref/ChangeLog
index 342c7c57175c08b1618e63757592d8631f62dec8..08ec4c2fef80628a48ac3ddd861ed88e9127f825 100644 (file)
--- a/doc/lispref/ChangeLog
+++ b/doc/lispref/ChangeLog
@@ -1,3 +1,9 @@
+2013-07-24  Paul Eggert  <eggert@cs.ucla.edu>
+
+       * eval.texi (Special Forms): Mention 'lambda'.  Also, say that
+       non-well-formed expressions result in unspecified behavior, though
+       Emacs will not crash.
+
 2013-07-22  Michael Albinus  <michael.albinus@gmx.de>
 
        * files.texi (Magic File Names): Add file-notify-add-watch,

diff --git a/doc/lispref/eval.texi b/doc/lispref/eval.texi
index 4b5ef1873832f81abff4062c54033d224beed57e..4b83d575fef85fc9b7f23ad25d16892b6c20bbda 100644 (file)
--- a/doc/lispref/eval.texi
+++ b/doc/lispref/eval.texi
@@ -432,6 +432,14 @@ do.
 and which are used without evaluation.  Whether a particular argument is
 evaluated may depend on the results of evaluating other arguments.
 
+  If an expression's first symbol is that of a special form, the
+expression should follow the rules of that special form; otherwise,
+Emacs's behavior is not well-defined (though it will not crash).  For
+example, @code{((lambda (x) x . 3) 4)} contains a subexpression that
+begins with @code{lambda} but is not a well-formed @code{lambda}
+expression, so Emacs may signal an error, or may return 3 or 4 or
+@code{nil}, or may behave in other ways.
+
   Here is a list, in alphabetical order, of all of the special forms in
 Emacs Lisp with a reference to where each is described.
 
@@ -463,6 +471,9 @@ Emacs Lisp with a reference to where each is described.
 @item interactive
 @pxref{Interactive Call}
 
+@item lambda
+@pxref{Lambda Expressions}
+
 @item let
 @itemx let*
 @pxref{Local Variables}

diff --git a/etc/NEWS b/etc/NEWS
index e7d51a4033afd0e83fa5d4dd6a7bca34aed77533..facadac5c1cc3d73b8b8cc9656f8d527877e24fe 100644 (file)
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -538,14 +538,6 @@ file using `set-file-extended-attributes'.
 ** `visited-file-modtime' now returns -1 for nonexistent files.
 Formerly it returned a list (-1 LOW USEC PSEC), but this was ambiguous
 in the presence of files with negative time stamps.
-
-** Special forms with implied progn now check for proper lists.
-Starting in Emacs 21.4, a special form with an implied progn of an
-improper list ignored the trailing value, treating it as nil.  For
-example, (cond (t (message "hello") . "there")) ignored the "there".
-This inadvertent change to Emacs's behavior has been reverted, and
-Emacs now signals an error for these improper forms, as it did in
-version 21.3 and earlier.
 \f
 * Lisp Changes in Emacs 24.4
 

diff --git a/src/ChangeLog b/src/ChangeLog
index 30cc0dcdac62d29ab74ae97524e435cba8a9fb20..51a5da688776e80fb53017e89556e59b6d911c99 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,10 @@
+2013-07-24  Paul Eggert  <eggert@cs.ucla.edu>
+
+       * eval.c (Fprogn): Do not check that BODY is a proper list.
+       This undoes the previous change.  The check slows down the
+       interpreter, and is not needed to prevent a crash.  See
+       <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
+
 2013-07-23  Glenn Morris  <rgm@gnu.org>
 
        * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.

diff --git a/src/eval.c b/src/eval.c
index e6ccf0bdcb50bb591cbdda7e1b018d4b806753ba..6cb2b7a92b8d5bc6db36107df42ee4c8bbb70962 100644 (file)
--- a/src/eval.c
+++ b/src/eval.c
@@ -454,12 +454,6 @@ usage: (progn BODY...)  */)
       body = XCDR (body);
     }
 
-  if (!NILP (body))
-    {
-      /* This can happen if functions like Fcond are the caller.  */
-      wrong_type_argument (Qlistp, body);
-    }
-
   UNGCPRO;
   return val;
 }