]> git.eshelyaron.com Git - emacs.git/commitdiff
Fix tempfile creation when byte compiling
authorPaul Eggert <eggert@cs.ucla.edu>
Fri, 19 Jan 2018 22:37:31 +0000 (14:37 -0800)
committerPaul Eggert <eggert@cs.ucla.edu>
Fri, 19 Jan 2018 22:40:56 +0000 (14:40 -0800)
This improves on the recent fix for master failing to build
on FreeBSD.  Suggested by Stefan Monnier in:
https://lists.gnu.org/r/emacs-devel/2018-01/msg00600.html
* lisp/emacs-lisp/bytecomp.el (byte-compile-file):
Put tempfile next to the target file, as was the original intent.

lisp/emacs-lisp/bytecomp.el

index 700a7c16b587ac3566b4aad6db884403cd0596d7..f6d259ba9da611d017e5daef2d543a8cfd0011e5 100644 (file)
@@ -1933,17 +1933,7 @@ The value is non-nil if there were no errors, nil if errors."
                       ;; parallel bootstrap), it does not risk getting a
                       ;; half-finished file.  (Bug#4196)
                       (tempfile
-                        (if (file-name-absolute-p target-file)
-                            (make-temp-file target-file)
-                          ;; If target-file is relative and includes
-                          ;; leading directories, make-temp-file will
-                          ;; assume those leading directories exist
-                          ;; under temporary-file-directory, which might
-                          ;; not be true.  So strip leading directories
-                          ;; from relative file names before calling
-                          ;; make-temp-file.
-                          (make-temp-file
-                           (file-name-nondirectory target-file))))
+                       (make-temp-file (expand-file-name target-file)))
                       (default-modes (default-file-modes))
                       (temp-modes (logand default-modes #o600))
                       (desired-modes (logand default-modes #o666))