Handle "empty line" regexp in xref searches

* lisp/progmodes/xref.el (xref--collect-matches-1): Stop after one
match if re-search-forward doesn't move point (bug#23426).

* test/automated/xref-tests.el
(xref-collect-matches-finds-an-empty-line-regexp-match):
Uncomment test.

diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index 540c7b0e92573e518fc8910a0ac63479d860bf01..62cef23598873805e0d5efabd2009e0a4f8d3d3f 100644 (file)
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -1016,7 +1016,11 @@ directory, used as the root of the ignore globs."
     (syntax-propertize line-end)
     ;; FIXME: This results in several lines with the same
     ;; summary. Solve with composite pattern?
-    (while (re-search-forward regexp line-end t)
+    (while (and
+            ;; REGEXP might match an empty string.  Or line.
+            (or (null matches)
+                (> (point) line-beg))
+            (re-search-forward regexp line-end t))
       (let* ((beg-column (- (match-beginning 0) line-beg))
              (end-column (- (match-end 0) line-beg))
              (loc (xref-make-file-location file line beg-column))

diff --git a/test/automated/xref-tests.el b/test/automated/xref-tests.el
index 1b500c3c418551d6a4859509a9172111000b3b0d..28ca3511c228276d8eb9aa4f15403f9184474a82 100644 (file)
--- a/test/automated/xref-tests.el
+++ b/test/automated/xref-tests.el
@@ -28,10 +28,10 @@
     (should (equal 0 (xref-file-location-column (nth 0 locs))))
     (should (equal 4 (xref-file-location-column (nth 1 locs))))))
 
-;; (ert-deftest xref-collect-matches-finds-an-empty-line-regexp-match ()
-;;   (let* ((matches (xref-collect-matches "^$" "*" xref-tests-data-dir nil))
-;;          (locs (mapcar #'xref-item-location matches)))
-;;     (should (= 1 (length matches)))
-;;     (should (string-match-p "file2\\.txt\\'" (xref-location-group (nth 0 locs))))
-;;     (should (equal 1 (xref-location-line (nth 0 locs))))
-;;     (should (equal 0 (xref-file-location-column (nth 0 locs))))))
+(ert-deftest xref-collect-matches-finds-an-empty-line-regexp-match ()
+  (let* ((matches (xref-collect-matches "^$" "*" xref-tests-data-dir nil))
+         (locs (mapcar #'xref-item-location matches)))
+    (should (= 1 (length matches)))
+    (should (string-match-p "file2\\.txt\\'" (xref-location-group (nth 0 locs))))
+    (should (equal 1 (xref-location-line (nth 0 locs))))
+    (should (equal 0 (xref-file-location-column (nth 0 locs))))))