]> git.eshelyaron.com Git - emacs.git/commitdiff
* Don't install unnecessary trampolines (bug#69573)
authorAndrea Corallo <acorallo@gnu.org>
Fri, 15 Mar 2024 13:18:51 +0000 (14:18 +0100)
committerEshel Yaron <me@eshelyaron.com>
Mon, 18 Mar 2024 15:41:31 +0000 (16:41 +0100)
* lisp/emacs-lisp/comp-run.el (comp-subr-trampoline-install):
Check that subr-name actually matches the target subr.

(cherry picked from commit 005536285585bcdf5a67a01cdfd8e1242742f953)

lisp/emacs-lisp/comp-run.el

index 057760322ab3966647362bfc52eac735c9c1dab7..afb46e3cd199bee97e4e129e93d45a5274e5c900 100644 (file)
@@ -364,13 +364,15 @@ Return the trampoline if found or nil otherwise."
   (when (memq subr-name comp-warn-primitives)
     (warn "Redefining `%s' might break native compilation of trampolines."
           subr-name))
-  (unless (or (null native-comp-enable-subr-trampolines)
-              (memq subr-name native-comp-never-optimize-functions)
-              (gethash subr-name comp-installed-trampolines-h))
-    (cl-assert (subr-primitive-p (symbol-function subr-name)))
-    (when-let ((trampoline (or (comp-trampoline-search subr-name)
-                               (comp-trampoline-compile subr-name))))
-      (comp--install-trampoline subr-name trampoline))))
+  (let ((subr (symbol-function subr-name)))
+    (unless (or (not (string= subr-name (subr-name subr))) ;; (bug#69573)
+                (null native-comp-enable-subr-trampolines)
+                (memq subr-name native-comp-never-optimize-functions)
+                (gethash subr-name comp-installed-trampolines-h))
+      (cl-assert (subr-primitive-p subr))
+      (when-let ((trampoline (or (comp-trampoline-search subr-name)
+                                 (comp-trampoline-compile subr-name))))
+        (comp--install-trampoline subr-name trampoline)))))
 
 ;;;###autoload
 (defun native--compile-async (files &optional recursively load selector)