(require): Added Satyaki's comment regarding what needs to happen to

remove this defadvice which caused a little discussion on emacs-devel
today (see Subject: mh-e/mh-acros.el advices `require' incorrectly).

diff --git a/lisp/mh-e/ChangeLog b/lisp/mh-e/ChangeLog
index d7293a94546a9de1edd8d09918ed96d78fa0f20c..74b38dac688d5428c914bb94bb4f7df9265172ed 100644 (file)
--- a/lisp/mh-e/ChangeLog
+++ b/lisp/mh-e/ChangeLog
@@ -1,5 +1,10 @@
 2006-01-13  Bill Wohler  <wohler@newt.com>
 
+       * mh-acros.el (require): Added Satyaki's comment regarding what
+       needs to happen to remove this defadvice which caused a little
+       discussion on emacs-devel today (see Subject: mh-e/mh-acros.el
+       advices `require' incorrectly).
+
        * mh-search.el (mh-index-next-result-function): Add format to
        docstring.
        (mh-mairix-next-result): Use nil instead of () which doesn't stand

diff --git a/lisp/mh-e/mh-acros.el b/lisp/mh-e/mh-acros.el
index 7cd4ee9edb0d0502d27f9ae72561334e29e97e9d..e37705ea54f92fe170ad4dd7b1567ca915652ddb 100644 (file)
--- a/lisp/mh-e/mh-acros.el
+++ b/lisp/mh-e/mh-acros.el
@@ -150,6 +150,9 @@ more details."
                           (list 'nth ,x z)))
        (quote ,struct-name))))
 
+;; A better solution would be to use Stefan's change in bytecomp.el.
+;; If it were checked in, we can drop the advice to require and it
+;; will make things nicer elsewhere too.
 (defadvice require (around mh-prefer-el activate)
   "Modify `require' to load uncompiled MH-E files."
   (or (featurep (ad-get-arg 0))