Update bookmark sort indicator at proper time

This follows up to my commit 8b071c77b0d7 of 2022-04-24.  Thanks to
Manuel Giraud <manuel@ledu-giraud.fr> for reporting the buglet.

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 6c46268a342e4b45c3817e2f332099795d65b55e..c604395dd7db82a98c2ba7b8a9158ab3d4ccfdc1 100644 (file)
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -1823,7 +1823,6 @@ Don't affect the buffer ring order."
                  ,@(if bookmark-bmenu-toggle-filenames
                        (list location))])
               entries)))
-    (tabulated-list-init-header)
     ;; The value of `bookmark-sort-flag' might have changed since the
     ;; last time the buffer contents were generated, so re-check it.
     (if bookmark-sort-flag
@@ -1846,7 +1845,12 @@ Don't affect the buffer ring order."
       ;; `bookmark-sort-flag' will happen again and the buffer will
       ;; go back to a creation-order sort.  This is all expected
       ;; behavior, as documented in `bookmark-bmenu-mode'.
-      (setq tabulated-list-entries (reverse entries))))
+      (setq tabulated-list-entries (reverse entries)))
+    ;; Generate the header only after `tabulated-list-sort-key' is
+    ;; settled, because if that's non-nil then the sort-direction
+    ;; indicator will be shown in the named column, but if it's
+    ;; nil then the indicator will not be shown.
+    (tabulated-list-init-header))
   (tabulated-list-print t))
 
 ;;;###autoload