]> git.eshelyaron.com Git - emacs.git/commitdiff
Revert "Let delete-selection-mode work with popup-menu commands (Bug#27569)"
authorNoam Postavsky <npostavs@gmail.com>
Sat, 22 Jul 2017 12:07:37 +0000 (08:07 -0400)
committerNoam Postavsky <npostavs@gmail.com>
Sat, 22 Jul 2017 12:20:13 +0000 (08:20 -0400)
It turns out that this change is not needed, and it leaves several
command loops settings not done.

https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg00757.html
https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg00840.html

lisp/menu-bar.el

index 4a569783293cb518aeb07248a350b0b331f32a02..3ca7d1b5b3d21f5f681782ec8a0ae57e26ce0c0a 100644 (file)
@@ -2375,10 +2375,6 @@ FROM-MENU-BAR, if non-nil, means we are dropping one of menu-bar's menus."
       ;; `setup-specified-language-environment', for instance,
       ;; expects this to be set from a menu keymap.
       (setq last-command-event (car (last event)))
-      ;; Update `this-command' and run `pre-command-hook' so that
-      ;; things like `delete-selection-pre-hook' will work correctly.
-      (setq this-command cmd)
-      (run-hooks 'pre-command-hook)
       ;; mouse-major-mode-menu was using `command-execute' instead.
       (call-interactively cmd))))