* lisp/emacs-lisp/nadvice.el (add-function): Default simple vars to their

global bindings.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index b5487896f74d2fe734e4cd67189c34e6437db44f..9554625b6e4fd8da82c393a22d03cd58029a142a 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,8 @@
 2013-04-16  Stefan Monnier  <monnier@iro.umontreal.ca>
 
+       * emacs-lisp/nadvice.el (add-function): Default simple vars to their
+       global bindings.
+
        * doc-view.el (doc-view-start-process): Handle url-handler directories.
 
 2013-04-15  Dmitry Gutov  <dgutov@yandex.ru>

diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el
index db8a0753466d3d59613617d2bfd15bafafadcf7b..6c09ddfb8cf3ea3ed1af227aae51364ccdcde32c 100644 (file)
--- a/lisp/emacs-lisp/nadvice.el
+++ b/lisp/emacs-lisp/nadvice.el
@@ -236,9 +236,8 @@ PROPS is an alist of additional properties, among which the following have
 a special meaning:
 - `name': a string or symbol.  It can be used to refer to this piece of advice.
 
-PLACE cannot be a simple variable.  Instead it should either be
-\(default-value 'VAR) or (local 'VAR) depending on whether FUNCTION
-should be applied to VAR buffer-locally or globally.
+If PLACE is a simple variable, only its global value will be affected.
+Use (local 'VAR) if you want to apply FUNCTION to VAR buffer-locally.
 
 If one of FUNCTION or OLDFUN is interactive, then the resulting function
 is also interactive.  There are 3 cases:
@@ -251,7 +250,7 @@ is also interactive.  There are 3 cases:
   (cond ((eq 'local (car-safe place))
          (setq place `(advice--buffer-local ,@(cdr place))))
         ((symbolp place)
-         (error "Use (default-value '%S) or (local '%S)" place place)))
+         (setq place `(default-value ',place))))
   `(advice--add-function ,where (gv-ref ,place) ,function ,props))
 
 ;;;###autoload